Remove AutoFill from context menu when using contextMenuHidden#43468
Closed
jakex7 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove AutoFill from context menu when using contextMenuHidden#43468jakex7 wants to merge 1 commit intofacebook:mainfrom
contextMenuHidden#43468jakex7 wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@tdn120 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
Summary: PR #43468 landed in main which uses UIMenuAutoFill that is available only in iOS 17. Despite having the `available` checks, these are only runtime checks. The symbol is not stripped on older versions of Xcode and therefore our jobs which uses older Xcode versions started failing. This change wraps the offending code in a compilation pragma that strips away the symbol when building with Xcode versions that does not know iOS 17. ## Changelog: [iOS][Fixed] - wrap UIMenuAutoFill in compilation checks for iOS 17 Pull Request resolved: #43808 Test Plan: CircleCI is green Reviewed By: cortinico Differential Revision: D55688255 Pulled By: cipolleschi fbshipit-source-id: d69874b60e73da1fbdfc61d594870a48f97c3797
|
Hi, may I ask when this will be released and what the target RN version would be? |
This is part of 0.75. You can follow along here: React Native 0.75 Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request resolves the issue #43452
Previously, when utilizing
contextMenuHidden, the context menu wasn't entirely hidden as the "AutoFill" option remained visible. However, it's now possible to eliminate it using the menu builder.Changelog:
[IOS] [FIXED] - hide AutoFill from context menu when using
contextMenuHiddenTest Plan:
Manual tests in RNTester:
Nagranie.z.ekranu.2024-03-13.o.23.25.05.mov