Move several libs from default App CMake setup to static linking#43909
Closed
cortinico wants to merge 3 commits into
Closed
Move several libs from default App CMake setup to static linking#43909cortinico wants to merge 3 commits into
cortinico wants to merge 3 commits into
Conversation
Summary: This frees up the `reactnative` CMake target so we could use it as single .so for the CMake build. Changelog: [Internal] [Changed] - Rename reactnative.a -> react_cxxreact.a Differential Revision: D55745640
Summary: This creates a new dynamic library that we want to be the only .so that is loaded from apps/libraries. Changelog: [Internal] [Changed] - Create the libreactnative.so dependency Differential Revision: D55751682
Summary: As we're moving towards a single `libreactnative.so` file, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader. This is breaking for libraries using native dependencies via Prefab (i.e. search for `ReactAndroid::` in CMakeLists.txt files for your project). If so, the CMakeLists.txt files should be updated as follows: ```diff - ReactAndroid::react_render_debug + ReactAndroid::reactnative ``` This applies to every prefab dependencies (the example is just for `react_render_debug` Changelog: [General] [Breaking] - Remove several libs from default App CMake setup Differential Revision: D55751683
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751683 |
Contributor
Author
|
Closing as stale |
Contributor
Author
|
Close as stale |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751683 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751683 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 26, 2024
…ebook#43909) Summary: Pull Request resolved: facebook#43909 As we're moving towards a single `libreactnative.so` file, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader. This is breaking for libraries using native dependencies via Prefab (i.e. search for `ReactAndroid::` in CMakeLists.txt files for your project). If so, the CMakeLists.txt files should be updated as follows: ```diff - ReactAndroid::react_render_debug + ReactAndroid::reactnative ``` This applies to every prefab dependencies (the example is just for `react_render_debug` Changelog: [General] [Breaking] - Remove several libs from default App CMake setup bypass-github-export-checks Reviewed By: cipolleschi Differential Revision: D55751683
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
) Summary: Pull Request resolved: #43909 As we're moving towards a single `libreactnative.so` file, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader. This is breaking for libraries using native dependencies via Prefab (i.e. search for `ReactAndroid::` in CMakeLists.txt files for your project). If so, the CMakeLists.txt files should be updated as follows: ```diff - ReactAndroid::react_render_debug + ReactAndroid::reactnative ``` This applies to every prefab dependencies (the example is just for `react_render_debug` Changelog: [General] [Breaking] - Remove several libs from default App CMake setup Reviewed By: cipolleschi Differential Revision: D55751683 fbshipit-source-id: 3aca7897852b5f323d60ede3c5036cae2f81e6c3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As we're moving towards a single
libreactnative.sofile, we need to remove several of our prefab targets. Here I'm cleaning up those that are not having an OnLoad.cpp file which needs to be loaded from SoLoader.This is breaking for libraries using native dependencies via Prefab (i.e. search for
ReactAndroid::in CMakeLists.txt files for your project).If so, the CMakeLists.txt files should be updated as follows:
This applies to every prefab dependencies (the example is just for
react_render_debugChangelog:
[General] [Breaking] - Remove several libs from default App CMake setup
Differential Revision: D55751683