Skip to content

Move several libs from default App CMake setup to static linking #43909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 3 commits into from
Closed

Move several libs from default App CMake setup to static linking #43909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7127b7
Rename reactnative.a -> react_cxxreact.a
cortinico Apr 5, 2024
59f2e1f
Create the libreactnative.so dependency
cortinico Apr 5, 2024
9fc7853
Move several libs from default App CMake setup to static linking
cortinico Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions packages/react-native-codegen/src/generators/modules/GenerateModuleJniH.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,9 @@ target_include_directories(react_codegen_${libraryName} PUBLIC . react/renderer/
target_link_libraries(
react_codegen_${libraryName}
fbjni
folly_runtime
glog
jsi
${libraryName !== 'rncore' ? 'react_codegen_rncore' : ''}
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down
112 changes: 8 additions & 104 deletions ...ve-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleJniH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,21 +55,9 @@ target_include_directories(react_codegen_SampleWithUppercaseName PUBLIC . react/
target_link_libraries(
react_codegen_SampleWithUppercaseName
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -142,21 +130,9 @@ target_include_directories(react_codegen_complex_objects PUBLIC . react/renderer
target_link_libraries(
react_codegen_complex_objects
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -222,21 +198,9 @@ target_include_directories(react_codegen_cxx_only_native_modules PUBLIC . react/
target_link_libraries(
react_codegen_cxx_only_native_modules
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -309,21 +273,9 @@ target_include_directories(react_codegen_empty_native_modules PUBLIC . react/ren
target_link_libraries(
react_codegen_empty_native_modules
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -396,21 +348,9 @@ target_include_directories(react_codegen_native_modules_with_type_aliases PUBLIC
target_link_libraries(
react_codegen_native_modules_with_type_aliases
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -491,21 +431,9 @@ target_include_directories(react_codegen_real_module_example PUBLIC . react/rend
target_link_libraries(
react_codegen_real_module_example
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -578,21 +506,9 @@ target_include_directories(react_codegen_simple_native_modules PUBLIC . react/re
target_link_libraries(
react_codegen_simple_native_modules
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down Expand Up @@ -673,21 +589,9 @@ target_include_directories(react_codegen_two_modules_different_files PUBLIC . re
target_link_libraries(
react_codegen_two_modules_different_files
fbjni
folly_runtime
glog
jsi
react_codegen_rncore
react_debug
react_nativemodule_core
react_render_componentregistry
react_render_core
react_render_debug
react_render_graphics
react_render_imagemanager
react_render_mapbuffer
react_utils
rrc_image
rrc_view
reactnative
turbomodulejsijni
yoga
)
Expand Down
Loading