Fix crash of RNTester on back navigation by cortinico · Pull Request #43931 · facebook/react-native

cortinico · 2024-04-05T16:27:05Z

Summary:
RN Tester is crashing on back navigation with this stacktrace:

04-05 17:14:22.906 25051 25051 E AndroidRuntime: FATAL EXCEPTION: main
04-05 17:14:22.906 25051 25051 E AndroidRuntime: Process: com.facebook.react.uiapp, PID: 25051
04-05 17:14:22.906 25051 25051 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR, parameter view
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR(Unknown Source:2)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.facebook.react.ReactDelegate.shouldShowDevMenuOrReload(ReactDelegate.java:302)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.facebook.react.ReactActivityDelegate.onKeyUp(ReactActivityDelegate.java:158)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.facebook.react.ReactActivity.onKeyUp(ReactActivity.java:89)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.KeyEvent.dispatch(KeyEvent.java:2878)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.app.Activity.dispatchKeyEvent(Activity.java:4164)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:126)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:86)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:144)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:604)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3413)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:404)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:6377)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6243)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5946)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:6104)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3159)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2723)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2714)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3136)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:154)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.os.MessageQueue.nativePollOnce(Native Method)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.os.MessageQueue.next(MessageQueue.java:335)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:161)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:288)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7842)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
04-05 17:14:22.906 25051 25051 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

This is happening because the view: View parameter is actually null at that point. I'm fixing it.

Changelog:
[Internal] [Changed] - Fix crash of RNTester on back navigation

Differential Revision: D55805574

facebook-github-bot · 2024-04-05T16:27:22Z

This pull request was exported from Phabricator. Differential Revision: D55805574

Summary: Converting to Kotlin the `RuntimeConfig` class caused the project to stop compiling. Changelog: [Internal] [Changed] - Fix broken HermesExecutor compilation Differential Revision: D55805572

Summary: RN Tester is crashing on back navigation with this stacktrace: ``` 04-05 17:14:22.906 25051 25051 E AndroidRuntime: FATAL EXCEPTION: main 04-05 17:14:22.906 25051 25051 E AndroidRuntime: Process: com.facebook.react.uiapp, PID: 25051 04-05 17:14:22.906 25051 25051 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR, parameter view 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR(Unknown Source:2) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactDelegate.shouldShowDevMenuOrReload(ReactDelegate.java:302) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactActivityDelegate.onKeyUp(ReactActivityDelegate.java:158) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactActivity.onKeyUp(ReactActivity.java:89) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.KeyEvent.dispatch(KeyEvent.java:2878) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.app.Activity.dispatchKeyEvent(Activity.java:4164) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:126) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:86) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:144) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:604) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3413) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:404) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:6377) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6243) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5946) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:6104) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3159) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2723) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2714) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3136) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:154) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.MessageQueue.nativePollOnce(Native Method) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.MessageQueue.next(MessageQueue.java:335) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:161) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.Looper.loop(Looper.java:288) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7842) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) ``` This is happening because the `view: View` parameter is actually null at that point. I'm fixing it. Changelog: [Internal] [Changed] - Fix crash of RNTester on back navigation Differential Revision: D55805574

facebook-github-bot · 2024-04-05T16:28:05Z

This pull request was exported from Phabricator. Differential Revision: D55805574

Summary: RN Tester is crashing on back navigation with this stacktrace: ``` 04-05 17:14:22.906 25051 25051 E AndroidRuntime: FATAL EXCEPTION: main 04-05 17:14:22.906 25051 25051 E AndroidRuntime: Process: com.facebook.react.uiapp, PID: 25051 04-05 17:14:22.906 25051 25051 E AndroidRuntime: java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR, parameter view 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.devsupport.DoubleTapReloadRecognizer.didDoubleTapR(Unknown Source:2) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactDelegate.shouldShowDevMenuOrReload(ReactDelegate.java:302) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactActivityDelegate.onKeyUp(ReactActivityDelegate.java:158) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.facebook.react.ReactActivity.onKeyUp(ReactActivity.java:89) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.KeyEvent.dispatch(KeyEvent.java:2878) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.app.Activity.dispatchKeyEvent(Activity.java:4164) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.app.ComponentActivity.superDispatchKeyEvent(ComponentActivity.java:126) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(KeyEventDispatcher.java:86) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.core.app.ComponentActivity.dispatchKeyEvent(ComponentActivity.java:144) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(AppCompatActivity.java:604) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(WindowCallbackWrapper.java:60) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(AppCompatDelegateImpl.java:3413) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.policy.DecorView.dispatchKeyEvent(DecorView.java:404) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent(ViewRootImpl.java:6377) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6243) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5725) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5913) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:5970) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5756) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5729) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5782) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5748) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5946) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.ViewRootImpl$ImeInputStage.onFinishedInputEvent(ViewRootImpl.java:6104) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager$PendingEvent.run(InputMethodManager.java:3159) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager.invokeFinishedInputEventCallback(InputMethodManager.java:2723) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager.finishedInputEvent(InputMethodManager.java:2714) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.inputmethod.InputMethodManager$ImeInputEventSender.onInputEventFinished(InputMethodManager.java:3136) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.view.InputEventSender.dispatchInputEventFinished(InputEventSender.java:154) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.MessageQueue.nativePollOnce(Native Method) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.MessageQueue.next(MessageQueue.java:335) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.Looper.loopOnce(Looper.java:161) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.os.Looper.loop(Looper.java:288) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7842) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) 04-05 17:14:22.906 25051 25051 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) ``` This is happening because the `view: View` parameter is actually null at that point. I'm fixing it. Changelog: [Internal] [Changed] - Fix crash of RNTester on back navigation Reviewed By: tdn120 Differential Revision: D55805574

analysis-bot · 2024-04-05T17:03:24Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,918,797	+0
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,283,300	+6
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 03c75c2
Branch: main

facebook-github-bot · 2024-04-05T19:29:40Z

This pull request has been merged in d45b843.

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 5, 2024

facebook-github-bot added the fb-exported label Apr 5, 2024

cortinico added 2 commits April 5, 2024 09:27

[skip ci] Fix broken HermesExecutor compilation (facebook#43932)

7908661

Summary: Converting to Kotlin the `RuntimeConfig` class caused the project to stop compiling. Changelog: [Internal] [Changed] - Fix broken HermesExecutor compilation Differential Revision: D55805572

cortinico force-pushed the export-D55805574 branch from 0fc7144 to d3ed589 Compare April 5, 2024 16:27

facebook-github-bot closed this in d45b843 Apr 5, 2024

facebook-github-bot added the Merged This PR has been merged. label Apr 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash of RNTester on back navigation#43931

Fix crash of RNTester on back navigation#43931
cortinico wants to merge 2 commits into
facebook:mainfrom
cortinico:export-D55805574

cortinico commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

analysis-bot commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cortinico commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

analysis-bot commented Apr 5, 2024

Uh oh!

facebook-github-bot commented Apr 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants