Simplify debugger launch flow to invoke Chrome directly, drop kill API#44672
Closed
huntie wants to merge 2 commits into
Closed
Simplify debugger launch flow to invoke Chrome directly, drop kill API#44672huntie wants to merge 2 commits into
huntie wants to merge 2 commits into
Conversation
Summary: Reverts the debugger launch flow to use the default `ChromeLauncher` profile. This is the approach used in the current `--experimental-debugger` experiment and by Expo. This is motivated after a review of the tradeoffs of a guest profile — which allow us to programatically quit the browser process, however takes over system URL handling. Changelog: [Internal] Differential Revision: D57619542
Summary: Swaps out and simplifies the internals of the debugger launch flow. We observed that we could achieve better launch/windowing behaviour by passing the `--app` argument directly to the detected Chrome path. This shares the user's default Chrome profile: - Fixes unwanted behaviour such as a separate dock icon on macOS (which, when clicked, would launch an unwanted empty window). - Enables settings persistence. This change also removes the `LaunchedBrowser.kill` API. Changelog: [Internal] Differential Revision: D57726649
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57726649 |
Base commit: c13790f |
Contributor
|
This pull request has been merged in 5d827d8. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
facebook#44672) Summary: Pull Request resolved: facebook#44672 Swaps out and simplifies the internals of the debugger launch flow. We observed that we could achieve better launch/windowing behaviour by passing the `--app` argument directly to the detected Chrome path. This shares the user's default Chrome profile: - Fixes unwanted behaviour such as a separate dock icon on macOS (which, when clicked, would launch an unwanted empty window). - Enables settings persistence. This change also removes the `LaunchedBrowser.kill` API. Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D57726649 fbshipit-source-id: fc3a715dc852a50559048d1d1c378f64aeb2013f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Swaps out and simplifies the internals of the debugger launch flow.
We observed that we could achieve better launch/windowing behaviour by passing the
--appargument directly to the detected Chrome path.This shares the user's default Chrome profile:
This change also removes the
LaunchedBrowser.killAPI.Changelog: [Internal]
Differential Revision: D57726649