Skip to content

Asyncify ReactNativeTestTools.expectRendersMatchingSnapshot #44992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robhogan wants to merge 5 commits into from
Closed

Asyncify ReactNativeTestTools.expectRendersMatchingSnapshot #44992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdd6637
RN: Delete `jest/renderer` Shallow Render Helpers (#44984)
yungsters Jun 16, 2024
bba3bc6
RN: Delete Shallow Renderer Mock Tests (#44973)
yungsters Jun 16, 2024
162955b
RN: Remove `react-shallow-renderer` Dependency (#44982)
yungsters Jun 16, 2024
47522ae
Make jest/renderer `create` helper async in prep for concurrent
robhogan Jun 16, 2024
812b8bc
Asyncify ReactNativeTestTools.expectRendersMatchingSnapshot (#44992)
robhogan Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/react-native/Libraries/Components/ActivityIndicator/__tests__/ActivityIndicator-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ describe('<ActivityIndicator />', () => {
expect(ActivityIndicator.displayName).toBe('ActivityIndicator');
});

it('should render as expected', () => {
ReactNativeTestTools.expectRendersMatchingSnapshot(
it('should render as expected', async () => {
await ReactNativeTestTools.expectRendersMatchingSnapshot(
'ActivityIndicator',
() => <ActivityIndicator size="large" color="#0000ff" />,
() => {
Expand Down
14 changes: 0 additions & 14 deletions ...aries/Components/ActivityIndicator/__tests__/__snapshots__/ActivityIndicator-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,3 @@ exports[`<ActivityIndicator /> should render as expected: should deep render whe
/>
</View>
`;

exports[`<ActivityIndicator /> should render as expected: should shallow render as <ActivityIndicator /> when mocked 1`] = `
<ActivityIndicator
color="#0000ff"
size="large"
/>
`;

exports[`<ActivityIndicator /> should render as expected: should shallow render as <ActivityIndicator /> when not mocked 1`] = `
<ActivityIndicator
color="#0000ff"
size="large"
/>
`;
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Components/DrawerAndroid/__tests__/DrawerAndroid-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ const DrawerLayoutAndroid = require('../DrawerLayoutAndroid.android');
const React = require('react');

describe('<DrawerLayoutAndroid />', () => {
it('should render as expected', () => {
ReactNativeTestTools.expectRendersMatchingSnapshot(
it('should render as expected', async () => {
await ReactNativeTestTools.expectRendersMatchingSnapshot(
'DrawerLayoutAndroid',
() => (
<DrawerLayoutAndroid
Expand Down
16 changes: 0 additions & 16 deletions ...ive/Libraries/Components/DrawerAndroid/__tests__/__snapshots__/DrawerAndroid-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,3 @@ exports[`<DrawerLayoutAndroid /> should render as expected: should deep render w
</View>
</AndroidDrawerLayout>
`;

exports[`<DrawerLayoutAndroid /> should render as expected: should shallow render as <DrawerLayoutAndroid /> when mocked 1`] = `
<DrawerLayoutAndroid
drawerPosition="left"
drawerWidth={300}
renderNavigationView={[Function]}
/>
`;

exports[`<DrawerLayoutAndroid /> should render as expected: should shallow render as <DrawerLayoutAndroid /> when not mocked 1`] = `
<DrawerLayoutAndroid
drawerPosition="left"
drawerWidth={300}
renderNavigationView={[Function]}
/>
`;
20 changes: 10 additions & 10 deletions packages/react-native/Libraries/Components/Pressable/__tests__/Pressable-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import Pressable from '../Pressable';
import * as React from 'react';

describe('<Pressable />', () => {
it('should render as expected', () => {
expectRendersMatchingSnapshot(
it('should render as expected', async () => {
await expectRendersMatchingSnapshot(
'Pressable',
() => (
<Pressable>
Expand All @@ -31,8 +31,8 @@ describe('<Pressable />', () => {
});

describe('<Pressable disabled={true} />', () => {
it('should be disabled when disabled is true', () => {
expectRendersMatchingSnapshot(
it('should be disabled when disabled is true', async () => {
await expectRendersMatchingSnapshot(
'Pressable',
() => (
<Pressable disabled={true}>
Expand All @@ -47,8 +47,8 @@ describe('<Pressable disabled={true} />', () => {
});

describe('<Pressable disabled={true} accessibilityState={{}} />', () => {
it('should be disabled when disabled is true and accessibilityState is empty', () => {
expectRendersMatchingSnapshot(
it('should be disabled when disabled is true and accessibilityState is empty', async () => {
await expectRendersMatchingSnapshot(
'Pressable',
() => (
<Pressable disabled={true} accessibilityState={{}}>
Expand All @@ -63,8 +63,8 @@ describe('<Pressable disabled={true} accessibilityState={{}} />', () => {
});

describe('<Pressable disabled={true} accessibilityState={{checked: true}} />', () => {
it('should keep accessibilityState when disabled is true', () => {
expectRendersMatchingSnapshot(
it('should keep accessibilityState when disabled is true', async () => {
await expectRendersMatchingSnapshot(
'Pressable',
() => (
<Pressable disabled={true} accessibilityState={{checked: true}}>
Expand All @@ -79,8 +79,8 @@ describe('<Pressable disabled={true} accessibilityState={{checked: true}} />', (
});

describe('<Pressable disabled={true} accessibilityState={{disabled: false}} />', () => {
it('should overwrite accessibilityState with value of disabled prop', () => {
expectRendersMatchingSnapshot(
it('should overwrite accessibilityState with value of disabled prop', async () => {
await expectRendersMatchingSnapshot(
'Pressable',
() => (
<Pressable disabled={true} accessibilityState={{disabled: false}}>
Expand Down
98 changes: 0 additions & 98 deletions ...eact-native/Libraries/Components/Pressable/__tests__/__snapshots__/Pressable-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,6 @@ exports[`<Pressable /> should render as expected: should deep render when not mo
</View>
`;

exports[`<Pressable /> should render as expected: should shallow render as <Pressable /> when mocked 1`] = `
<Memo(Pressable)>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable /> should render as expected: should shallow render as <Pressable /> when not mocked 1`] = `
<Memo(Pressable)>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} /> should be disabled when disabled is true: should deep render when mocked (please verify output manually) 1`] = `
<View
accessibilityState={
Expand Down Expand Up @@ -156,22 +144,6 @@ exports[`<Pressable disabled={true} /> should be disabled when disabled is true:
</View>
`;

exports[`<Pressable disabled={true} /> should be disabled when disabled is true: should shallow render as <Pressable /> when mocked 1`] = `
<Memo(Pressable)
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} /> should be disabled when disabled is true: should shallow render as <Pressable /> when not mocked 1`] = `
<Memo(Pressable)
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disabled when disabled is true and accessibilityState is empty: should deep render when mocked (please verify output manually) 1`] = `
<View
accessibilityState={
Expand Down Expand Up @@ -244,24 +216,6 @@ exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disable
</View>
`;

exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disabled when disabled is true and accessibilityState is empty: should shallow render as <Pressable /> when mocked 1`] = `
<Memo(Pressable)
accessibilityState={Object {}}
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{}} /> should be disabled when disabled is true and accessibilityState is empty: should shallow render as <Pressable /> when not mocked 1`] = `
<Memo(Pressable)
accessibilityState={Object {}}
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> should keep accessibilityState when disabled is true: should deep render when mocked (please verify output manually) 1`] = `
<View
accessibilityState={
Expand Down Expand Up @@ -334,32 +288,6 @@ exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> shou
</View>
`;

exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> should keep accessibilityState when disabled is true: should shallow render as <Pressable /> when mocked 1`] = `
<Memo(Pressable)
accessibilityState={
Object {
"checked": true,
}
}
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{checked: true}} /> should keep accessibilityState when disabled is true: should shallow render as <Pressable /> when not mocked 1`] = `
<Memo(Pressable)
accessibilityState={
Object {
"checked": true,
}
}
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> should overwrite accessibilityState with value of disabled prop: should deep render when mocked (please verify output manually) 1`] = `
<View
accessibilityState={
Expand Down Expand Up @@ -431,29 +359,3 @@ exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> sh
<View />
</View>
`;

exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> should overwrite accessibilityState with value of disabled prop: should shallow render as <Pressable /> when mocked 1`] = `
<Memo(Pressable)
accessibilityState={
Object {
"disabled": false,
}
}
disabled={true}
>
<View />
</Memo(Pressable)>
`;

exports[`<Pressable disabled={true} accessibilityState={{disabled: false}} /> should overwrite accessibilityState with value of disabled prop: should shallow render as <Pressable /> when not mocked 1`] = `
<Memo(Pressable)
accessibilityState={
Object {
"disabled": false,
}
}
disabled={true}
>
<View />
</Memo(Pressable)>
`;
4 changes: 2 additions & 2 deletions ...react-native/Libraries/Components/ProgressBarAndroid/__tests__/ProgressBarAndroid-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ const ProgressBarAndroid = require('../ProgressBarAndroid.android');
const React = require('react');

describe('<ProgressBarAndroid />', () => {
it('should render as expected', () => {
ReactNativeTestTools.expectRendersMatchingSnapshot(
it('should render as expected', async () => {
await ReactNativeTestTools.expectRendersMatchingSnapshot(
'ProgressBarAndroid',
() => <ProgressBarAndroid styleAttr="Horizontal" indeterminate={true} />,
() => {
Expand Down
14 changes: 0 additions & 14 deletions ...ies/Components/ProgressBarAndroid/__tests__/__snapshots__/ProgressBarAndroid-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,3 @@ exports[`<ProgressBarAndroid /> should render as expected: should deep render wh
styleAttr="Horizontal"
/>
`;

exports[`<ProgressBarAndroid /> should render as expected: should shallow render as <ProgressBarAndroid /> when mocked 1`] = `
<ForwardRef(ProgressBarAndroid)
indeterminate={true}
styleAttr="Horizontal"
/>
`;

exports[`<ProgressBarAndroid /> should render as expected: should shallow render as <ProgressBarAndroid /> when not mocked 1`] = `
<ForwardRef(ProgressBarAndroid)
indeterminate={true}
styleAttr="Horizontal"
/>
`;
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Components/SafeAreaView/__tests__/SafeAreaView-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const View = require('../../View/View');
const React = require('react');

describe('<SafeAreaView />', () => {
it('should render as expected', () => {
ReactNativeTestTools.expectRendersMatchingSnapshot(
it('should render as expected', async () => {
await ReactNativeTestTools.expectRendersMatchingSnapshot(
'SafeAreaView',
() => (
<SafeAreaView>
Expand Down
20 changes: 0 additions & 20 deletions ...ative/Libraries/Components/SafeAreaView/__tests__/__snapshots__/SafeAreaView-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,3 @@ exports[`<SafeAreaView /> should render as expected: should deep render when not
</View>
</RCTSafeAreaView>
`;

exports[`<SafeAreaView /> should render as expected: should shallow render as <SafeAreaView /> when mocked 1`] = `
<RCTSafeAreaView>
<View>
<Text>
Hello World!
</Text>
</View>
</RCTSafeAreaView>
`;

exports[`<SafeAreaView /> should render as expected: should shallow render as <SafeAreaView /> when not mocked 1`] = `
<RCTSafeAreaView>
<View>
<Text>
Hello World!
</Text>
</View>
</RCTSafeAreaView>
`;
4 changes: 2 additions & 2 deletions packages/react-native/Libraries/Components/ScrollView/__tests__/ScrollView-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ describe('ScrollView', () => {
jest.resetModules();
});

it('renders its children', () => {
ReactNativeTestTools.expectRendersMatchingSnapshot(
it('renders its children', async () => {
await ReactNativeTestTools.expectRendersMatchingSnapshot(
'ScrollView',
() => (
<ScrollView>
Expand Down
20 changes: 0 additions & 20 deletions ...ct-native/Libraries/Components/ScrollView/__tests__/__snapshots__/ScrollView-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,23 +65,3 @@ exports[`ScrollView renders its children: should deep render when not mocked (pl
</RCTScrollContentView>
</RCTScrollView>
`;

exports[`ScrollView renders its children: should shallow render as <ScrollView /> when mocked 1`] = `
<ScrollView>
<View>
<Text>
Hello World!
</Text>
</View>
</ScrollView>
`;

exports[`ScrollView renders its children: should shallow render as <ScrollView /> when not mocked 1`] = `
<ScrollView>
<View>
<Text>
Hello World!
</Text>
</View>
</ScrollView>
`;
8 changes: 4 additions & 4 deletions packages/react-native/Libraries/Components/TextInput/__tests__/InputAccessoryView-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ const InputAccessoryView = require('../InputAccessoryView').default;
const React = require('react');

describe('InputAccessoryView', () => {
it('should render as <RCTInputAccessoryView> when mocked', () => {
const instance = render.create(
it('should render as <RCTInputAccessoryView> when mocked', async () => {
const instance = await render.create(
<InputAccessoryView nativeID="1">
<View />
</InputAccessoryView>,
);
expect(instance).toMatchSnapshot();
});

it('should render as <RCTInputAccessoryView> when not mocked', () => {
it('should render as <RCTInputAccessoryView> when not mocked', async () => {
jest.dontMock('../InputAccessoryView');

const instance = render.create(
const instance = await render.create(
<InputAccessoryView nativeID="1">
<View />
</InputAccessoryView>,
Expand Down
Loading