Asyncify ReactNativeTestTools.expectRendersMatchingSnapshot#44992
Closed
robhogan wants to merge 5 commits into
Closed
Asyncify ReactNativeTestTools.expectRendersMatchingSnapshot#44992robhogan wants to merge 5 commits into
robhogan wants to merge 5 commits into
Conversation
Summary: Pull Request resolved: facebook#44984 Deletes the `jest/renderer` shallow render helpers. The commit stack below this already migrated all references to `shallow` and `shallowRender`. Changelog: [Internal] Differential Revision: D58643063
Summary: Pull Request resolved: facebook#44973 Changes `expectRendersMatchingSnapshot` to no longer make assertions about shallow rendering, because shallow rendering is now deprecated. Changelog: [Internal] Differential Revision: D58643365
Summary: Pull Request resolved: facebook#44982 Removes `react-shallow-renderer` dependency from the `react-native` package because it is no longer used. Changelog: [Internal] Differential Revision: D58643454
Differential Revision: D58647827
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58647828 |
…#44992) Summary: Pull Request resolved: facebook#44992 To allow for async `act` in a subsequent diff, make this utility method async and awaited at all call sites. Changelog: [Internal] Differential Revision: D58647828
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58647828 |
robhogan
force-pushed
the
export-D58647828
branch
from
9087e1a to
812b8bc
Compare
Contributor
|
This pull request has been merged in 910e713. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
To allow for async
actin a subsequent diff, make this utility method async and awaited at all call sites.Changelog: [Internal]
Differential Revision: D58647828