Receive the onUserDrivenAnimationEnded event in JS#45383
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
Base commit: c1b4133 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
45ab426 to
40a61a4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
40a61a4 to
a368590
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
a368590 to
88245b5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
88245b5 to
7a301f1
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 15, 2024
Summary: Pull Request resolved: facebook#45383 This is the second step required to fix the onTouchMove event in the new architecture. In this change, we are retrieving the list of nodes that are connected by the animation, and we are sending an event to the nodes so that we can trigger the commit. ## Changelog [iOS][Added] - retrieve the tags of the nodes connected by the animation and send them to JS Differential Revision: D59524617
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
7a301f1 to
88f5142
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
88f5142 to
da51436
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
da51436 to
66bed1a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
66bed1a to
588366c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
588366c to
675b9da
Compare
Summary: Pull Request resolved: facebook#45382 This change is the first step to tr and solve the pressability's `onTouchMove` issue with animation driven natively in the New Architecture. The idea is to trigger a special event from native to let JS know that a scroll event has ended (`scrollViewDidEndDragging` or `scrollViewdidEndDecelerating`). When this happens, we need to send an event to JS to let him know that it has to sync the Native Tree with the Shadow Tree. Step 2 is to connect Native with JS ## Changelog: [iOS][Added] - Send onScrollEnded event to NativeTurboAnimatedModule Differential Revision: D59459989 Reviewed By: sammy-SC
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45383 This is the second step required to fix the onTouchMove event in the new architecture. In this change, we are retrieving the list of nodes that are connected by the animation, and we are sending an event to the nodes so that we can trigger the commit. ## Changelog [iOS][Added] - retrieve the tags of the nodes connected by the animation and send them to JS Differential Revision: D59524617 Reviewed By: sammy-SC
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
675b9da to
52bbb12
Compare
Summary: Pull Request resolved: facebook#45383 This is the second step required to fix the onTouchMove event in the new architecture. In this change, we are retrieving the list of nodes that are connected by the animation, and we are sending an event to the nodes so that we can trigger the commit. ## Changelog [iOS][Added] - retrieve the tags of the nodes connected by the animation and send them to JS Reviewed By: sammy-SC Differential Revision: D59524617
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59524617 |
cipolleschi
force-pushed
the
export-D59524617
branch
from
52bbb12 to
6215436
Compare
Contributor
|
This pull request has been merged in fd748ae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is the second step required to fix the onTouchMove event in the new architecture.
In this change, we are retrieving the list of nodes that are connected by the animation, and we are sending an event to the nodes so that we can trigger the commit.
Changelog
[iOS][Added] - retrieve the tags of the nodes connected by the animation and send them to JS
Differential Revision: D59524617