feat: expose prefabs for newly added targets#45386
Closed
WoLewicki wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
cortinico
requested changes
Jul 11, 2024
| add_library(react_render_imagemanager ALIAS ReactAndroid::react_render_imagemanager) | ||
| add_library(rrc_image ALIAS ReactAndroid::rrc_image) | ||
| add_library(rrc_legacyviewmanagerinterop ALIAS ReactAndroid::rrc_legacyviewmanagerinterop) | ||
| add_library(reactnativejni ALIAS ReactAndroid::reactnativejni) |
Contributor
There was a problem hiding this comment.
This feels wrong @WoLewicki, I don't believe you need it.
Are you sure about this target?
Contributor
Author
There was a problem hiding this comment.
Let me check what fails if I remove it in the example app in a minute.
Contributor
Author
There was a problem hiding this comment.
It is needed in TextLayoutManager for facebook::react::NativeArray::consume():
cortinico
approved these changes
Jul 11, 2024
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in c16761d. |
|
This pull request was successfully merged by @WoLewicki in c16761d. When will my fix make it into a release? | How to file a pick request? |
Contributor
|
@WoLewicki can you open a pick request for this one? |
Contributor
Author
|
Done |
blakef
pushed a commit
that referenced
this pull request
Jul 15, 2024
Summary: In recent commits, some new targets have been added, and they are not exposed as prefabs, yet are used in e.g. `TextLayoutManager`. They are needed then for `react-native-live-markdown`: Expensify/react-native-live-markdown@c1611cd ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [ADDED] - expose prefabs for newly added targets Pull Request resolved: #45386 Test Plan: It cannot be tested inside the repo, but try to build the `example` app with new arch enabled on `Android` in the `react-native-live-markdown` repo to see that those are needed. Reviewed By: NickGerleman Differential Revision: D59638801 Pulled By: cortinico fbshipit-source-id: 3d09507d72a0c4d3dbb3a2a81b753625230a04a3
This was referenced Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In recent commits, some new targets have been added, and they are not exposed as prefabs, yet are used in e.g.
TextLayoutManager. They are needed then forreact-native-live-markdown: Expensify/react-native-live-markdown@c1611cdChangelog:
[ANDROID] [ADDED] - expose prefabs for newly added targets
Test Plan:
It cannot be tested inside the repo, but try to build the
exampleapp with new arch enabled onAndroidin thereact-native-live-markdownrepo to see that those are needed.