Skip to content

feat: expose prefabs for newly added targets #45386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WoLewicki wants to merge 1 commit into from
Closed

feat: expose prefabs for newly added targets #45386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/react-native/ReactAndroid/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,18 @@ val preparePrefab by
Pair("../ReactCommon/react/renderer/graphics/", "react/renderer/graphics/"),
Pair("../ReactCommon/react/renderer/graphics/platform/android/", ""),
)),
PrefabPreprocessingEntry(
"react_render_consistency",
Pair("../ReactCommon/react/renderer/consistency/", "react/renderer/consistency/")),
PrefabPreprocessingEntry(
"react_featureflags",
Pair("../ReactCommon/react/featureflags/", "react/featureflags/")),
PrefabPreprocessingEntry(
"react_performance_timeline",
Pair("../ReactCommon/react/performance/timeline/", "react/performance/timeline/")),
PrefabPreprocessingEntry(
"react_render_observers_events",
Pair("../ReactCommon/react/renderer/observers/events/", "react/renderer/observers/events/")),
PrefabPreprocessingEntry(
"rrc_root",
Pair(
Expand Down Expand Up @@ -694,6 +706,18 @@ android {
create("react_render_graphics") {
headers = File(prefabHeadersDir, "react_render_graphics").absolutePath
}
create("react_render_consistency") {
headers = File(prefabHeadersDir, "react_render_consistency").absolutePath
}
create("react_featureflags") {
headers = File(prefabHeadersDir, "react_featureflags").absolutePath
}
create("react_performance_timeline") {
headers = File(prefabHeadersDir, "react_performance_timeline").absolutePath
}
create("react_render_observers_events") {
headers = File(prefabHeadersDir, "react_render_observers_events").absolutePath
}
create("rrc_image") { headers = File(prefabHeadersDir, "rrc_image").absolutePath }
create("rrc_root") { headers = File(prefabHeadersDir, "rrc_root").absolutePath }
create("rrc_view") { headers = File(prefabHeadersDir, "rrc_view").absolutePath }
Expand Down
5 changes: 5 additions & 0 deletions packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ add_library(react_nativemodule_core ALIAS ReactAndroid::react_nativemodule_core)
add_library(react_render_imagemanager ALIAS ReactAndroid::react_render_imagemanager)
add_library(rrc_image ALIAS ReactAndroid::rrc_image)
add_library(rrc_legacyviewmanagerinterop ALIAS ReactAndroid::rrc_legacyviewmanagerinterop)
add_library(reactnativejni ALIAS ReactAndroid::reactnativejni)
Copy link
Copy Markdown
Contributor

@cortinico cortinico Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong @WoLewicki, I don't believe you need it.
Are you sure about this target?

Copy link
Copy Markdown
Contributor Author

@WoLewicki WoLewicki Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check what fails if I remove it in the example app in a minute.

Copy link
Copy Markdown
Contributor Author

@WoLewicki WoLewicki Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed in TextLayoutManager for facebook::react::NativeArray::consume():

react-native/packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp

Line 193 in c4a6bbc

auto dynamicArray = cthis(array)->consume();

image

add_library(react_render_consistency ALIAS ReactAndroid::react_render_consistency)
add_library(react_performance_timeline ALIAS ReactAndroid::react_performance_timeline)
add_library(react_render_observers_events ALIAS ReactAndroid::react_render_observers_events)
add_library(react_featureflags ALIAS ReactAndroid::react_featureflags)

find_package(fbjni REQUIRED CONFIG)
add_library(fbjni ALIAS fbjni::fbjni)
Expand Down