fix: add headers in fabric image component#45415
Closed
deepanshushuklad11 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@cipolleschi Checks are failing . I am not sure why. |
Contributor
|
@deepanshushuklad11 main is currently not stable. Once it stabilises, rebase off that commit.
|
Base commit: d2773f0 |
Contributor
Author
Thanks @blakef |
Contributor
|
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request was successfully merged by @deepanshushuklad11 in 50f7892 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES 45404
Summary:
sending headers from Image component not working in new arch , implementation was missing
<Image source={{ uri: "http://localhost:3000/image", headers: { "test-header": 'test', "hello":"tested" } }} style={{ width: 300, height: 300, }} />Changelog:
[IOS] [ADDED]- sending missing headers field with Image component in fabric
Test Plan:
Tested
Attaching the below video to show how headers are getting received on server from Image component running in new arch
Screen.Recording.2024-07-12.at.8.15.37.PM.1.1.mov