Skip to content

fix: add headers in fabric image component #45415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepanshushuklad11 wants to merge 2 commits into from
Closed

fix: add headers in fabric image component #45415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4101aac
fix: add image header in fabric image component
deepanshushuklad11 Jul 12, 2024
3277bd9
refactor: change code formatting
deepanshushuklad11 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/components/image/conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,17 @@ inline void fromRawValue(
result.type = ImageSource::Type::Local;
}

if (items.find("headers") != items.end() &&
items.at("headers").hasType<std::unordered_map<std::string, RawValue>>()) {
auto headers = (std::unordered_map<std::string, RawValue>)items.at("headers");
for (const auto &header : headers) {
if (header.second.hasType<std::string>()) {
result.headers[header.first] = (std::string)header.second;
}
}
// Add a debug log to print the headers
LOG(INFO) << "Parsed headers: " << result.headers.size();
}
return;
}

Expand Down
5 changes: 5 additions & 0 deletions ...rer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ inline static NSURLRequest *NSURLRequestFromImageSource(const facebook::react::I
request.cachePolicy = ...;
request.allHTTPHeaderFields = ...;
*/
// Set headers
for (const auto &header : imageSource.headers) {
[request setValue:[NSString stringWithUTF8String:header.second.c_str()]
forHTTPHeaderField:[NSString stringWithUTF8String:header.first.c_str()]];
}

return [request copy];
}
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/imagemanager/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ class ImageSource {
std::string bundle{};
Float scale{3};
Size size{0};
std::unordered_map<std::string, std::string> headers{}; // Add headers field


bool operator==(const ImageSource& rhs) const {
return std::tie(this->type, this->uri) == std::tie(rhs.type, rhs.uri);
Expand Down