fix: change opacity logic from random to decrement by -0.20#46830
fix: change opacity logic from random to decrement by -0.20#46830sarthak-d11 wants to merge 2 commits into
Conversation
|
Hi @sarthak-d11! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
CLA Signed
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks @sarthak-d11 for taking a stance at that. However, I don't think that the current implementation is working as we expect. Can you check the comment I left, please?
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for the PR and thanks for the patience. I'd update the function name as it could be misleading. But looks good, aside for this.
| } | ||
| const opacityDecrementCounter = 0.2; | ||
|
|
||
| function getOpacity(opacity: number): number { |
There was a problem hiding this comment.
| function getOpacity(opacity: number): number { | |
| function computeNextOpacity(opacity: number): number { |
Can we change the name of the function to make clearer what's its purpose? Otherwise it looks like it should return the opacity value, but it is actually doing much more.
There was a problem hiding this comment.
I have updated the function name as you said. Please review
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing job, thank you so much
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in af49070. |
|
This pull request was successfully merged by @sarthak-d11 in af49070 When will my fix make it into a release? | How to file a pick request? |
4 participants
Summary:
Part of this: #46757
Solves:
ME2E0003
Changelog:
[ Internal ] [ Changed ] - The opacity logic is changed from random to decrement the opacity by -0.2
For more details, see:
Test Plan:
yarn e2e-test-ios
yarn e2e-test-android