Skip to content

fix: change opacity logic from random to decrement by -0.20 #46830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarthak-d11 wants to merge 2 commits into from
Closed

fix: change opacity logic from random to decrement by -0.20 #46830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e5c43
fix: change opacity login from random to decrement by -0.20
sarthak-d11 Oct 3, 2024
f13276e
chore: updated the funtion name
sarthak-d11 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/rn-tester/NativeComponentExample/js/MyNativeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,14 @@ function getTextFor(measureStruct: MeasureStruct): string {
measureStruct.height,
)}`;
}
const opacityDecrementCounter = 0.2;

function computeNextOpacity(opacity: number): number {
if (parseFloat(opacity.toFixed(1)) > 0.0) {
return opacity - opacityDecrementCounter;
}
return 1.0;
}

// This is an example component that migrates to use the new architecture.
export default function MyNativeView(props: {}): React.Node {
Expand Down Expand Up @@ -201,7 +209,7 @@ export default function MyNativeView(props: {}): React.Node {
<Button
title="Set Opacity"
onPress={() => {
setOpacity(Math.random());
setOpacity(computeNextOpacity(opacity));
setArrayValues([
Math.floor(Math.random() * 100),
Math.floor(Math.random() * 100),
Expand Down