Fix stale reference to ReactViewGroup#mAllChildren #47950
Closed
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [Internal] Reviewed By: tdn120 Differential Revision: D66469161
Summary: `addInArray` may reallocate `mAllChildren` so it's not correct to store this reference. Changelog: [Internal] Reviewed By: tdn120 Differential Revision: D66474532
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66474532 |
Contributor
|
This pull request has been merged in 8869fa4. |
robhogan
pushed a commit
that referenced
this pull request
Dec 2, 2024
Summary: Pull Request resolved: #47950 `addInArray` may reallocate `mAllChildren` so it's not correct to store this reference. Changelog: [Internal] Reviewed By: tdn120 Differential Revision: D66474532 fbshipit-source-id: 90ce2fcbf8ff236501ed47b2acc413e54ef8b82a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
addInArraymay reallocatemAllChildrenso it's not correct to store this reference.Changelog: [Internal]
Reviewed By: tdn120
Differential Revision: D66474532