Restore deprecated TurboReactPackage#48039
Closed
javache wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66648209 |
Summary: This class was removed in D66127067 but was marked as DeprecatedInNewArchitecture and not Deprecated, which limited the signal we gave to developers to move away from this. Restore for now to e Changelog: [Android][Fixed] Reverted removal of TurboReactPackage Differential Revision: D66648209
997da3c to
58fc2b1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66648209 |
Contributor
|
This pull request has been merged in 70a9574. |
Collaborator
|
This pull request was successfully merged by @javache in 70a9574 When will my fix make it into a release? | How to file a pick request? |
robhogan
pushed a commit
that referenced
this pull request
Dec 2, 2024
Summary: Pull Request resolved: #48039 This class was removed in D66127067 but was marked as DeprecatedInNewArchitecture and not Deprecated, which limited the signal we gave to developers to move away from this. Restore for now to e Changelog: [Android][Fixed] Reverted removal of TurboReactPackage Reviewed By: rshest Differential Revision: D66648209 fbshipit-source-id: 165f9390b4874e69353612b929d87b0c495588af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This class was removed in D66127067 but was marked as DeprecatedInNewArchitecture and not Deprecated, which limited the signal we gave to developers to move away from this.
Restore for now to reduce the impact to community packages, which may not have been made aware of this deprecation.
Changelog: [Android][Fixed] Reverted removal of TurboReactPackage
Differential Revision: D66648209