VirtualizedList: Delete Batchinator#48515
Conversation
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67885194 |
yungsters
force-pushed
the
export-D67885194
branch
from
ecbc9e5 to
46f92b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67885194 |
Summary: Currently, `VirtualizedList-test.js` has a subtle dependency on how asynchronous operations are queued. Specifically, it depends on... - `Batchinator` to use `setTimeout` for... - `InteractionManager` to use `setImmediate` for... - `InteractionManager` to resolve a promise via microtask. As a consequence, any changes to this queueing logic (e.g. eliminating the unnecessary `setImmediate` and microtask) unnecessarily breaks these unit tests. This changes the Jest unit tests to instead use `jest. advanceTimersToNextTimer(<step>)` instead of `jest.runOnlyPendingTimers()` so that the unit tests are no longer dependent on these specific queueing logic. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D68449850
Summary: Deletes `Batchinator`, inlines the timer, and cleans up the `disableInteractionManagerInBatchinator` feature flag. Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D67885194
yungsters
force-pushed
the
export-D67885194
branch
from
46f92b5 to
9f4085d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67885194 |
Summary: Pull Request resolved: facebook#48515 Deletes `Batchinator`, inlines the timer, and cleans up the `disableInteractionManagerInBatchinator` feature flag. Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D67885194
|
This pull request has been merged in c8a387c. |
|
This pull request was successfully merged by @yungsters in c8a387c When will my fix make it into a release? | How to file a pick request? |
|
@yungsters When is that supposed to be avaible I'm getting strange issue with
Not sure why… |
|
This change should’ve been included in 0.78. The issue you’re seeing shouldn’t be happening, unless you are using mismatched versions of |
Yep ! I'm refactoring a monorepo from a customer, had to remove this line in metro config was related to such config, i changed it now its okay |
4 participants
Summary:
Deletes
Batchinator, inlines the timer, and cleans up thedisableInteractionManagerInBatchinatorfeature flag.Changelog:
[Internal]
Differential Revision: D67885194