VirtualizedList: More Resilient Unit Tests#48819
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68449850 |
Summary: Currently, `VirtualizedList-test.js` has a subtle dependency on how asynchronous operations are queued. Specifically, it depends on... - `Batchinator` to use `setTimeout` for... - `InteractionManager` to use `setImmediate` for... - `InteractionManager` to resolve a promise via microtask. As a consequence, any changes to this queueing logic (e.g. eliminating the unnecessary `setImmediate` and microtask) unnecessarily breaks these unit tests. This changes the Jest unit tests to instead use `jest. advanceTimersToNextTimer(<step>)` instead of `jest.runOnlyPendingTimers()` so that the unit tests are no longer dependent on these specific queueing logic. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D68449850
yungsters
force-pushed
the
export-D68449850
branch
from
0352e02 to
dd460fc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68449850 |
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jan 21, 2025
Summary: Currently, `VirtualizedList-test.js` has a subtle dependency on how asynchronous operations are queued. Specifically, it depends on... - `Batchinator` to use `setTimeout` for... - `InteractionManager` to use `setImmediate` for... - `InteractionManager` to resolve a promise via microtask. As a consequence, any changes to this queueing logic (e.g. eliminating the unnecessary `setImmediate` and microtask) unnecessarily breaks these unit tests. This changes the Jest unit tests to instead use `jest. advanceTimersToNextTimer(<step>)` instead of `jest.runOnlyPendingTimers()` so that the unit tests are no longer dependent on these specific queueing logic. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D68449850
Contributor
|
This pull request has been merged in 0ead7de. |
Collaborator
|
This pull request was successfully merged by @yungsters in 0ead7de When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
VirtualizedList-test.jshas a subtle dependency on how asynchronous operations are queued. Specifically, it depends on...Batchinatorto usesetTimeoutfor...InteractionManagerto usesetImmediatefor...InteractionManagerto resolve a promise via microtask.As a consequence, any changes to this queueing logic (e.g. eliminating the unnecessary
setImmediateand microtask) unnecessarily breaks these unit tests.This changes the Jest unit tests to instead use
jest. advanceTimersToNextTimer(<step>)instead ofjest.runOnlyPendingTimers()so that the unit tests are no longer dependent on these specific queueing logic.Changelog:
[Internal]
Differential Revision: D68449850