Split stopTracingAndCollectEvents#48795
Closed
hoxyq wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68331485 |
Summary: # Changelog: [Internal] This is the pre-requisite before adding a formatter for conversion from Hermes format-agnostic API for JavaScript samples to Trace Events. This struct will probably be used a lot around this module and big enough for a separate header. Reviewed By: huntie Differential Revision: D68104202
Summary: # Changelog: [Internal] Splitting `PerformanceTracer::stopTracingAndCollectEvents()` into 2 separate methods. Once we add logic for starting and stopping tracing on `InstanceAgent`: - We would need to stop tracing everywhere synchronously - Populate data sources in `PerformanceTracer`, like JavaScript samples - Collect all events from different data sources in one payload via `PerformanceTracer::collectEvents()` Differential Revision: D68331485
hoxyq
force-pushed
the
export-D68331485
branch
from
36b1829 to
95f016c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68331485 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 23, 2025
Summary: Pull Request resolved: facebook#48795 # Changelog: [Internal] Splitting `PerformanceTracer::stopTracingAndCollectEvents()` into 2 separate methods. Once we add logic for starting and stopping tracing on `InstanceAgent`: - We would need to stop tracing everywhere synchronously - Populate data sources in `PerformanceTracer`, like JavaScript samples - Collect all events from different data sources in one payload via `PerformanceTracer::collectEvents()` Differential Revision: D68331485
Contributor
|
This pull request has been merged in df4d9d1. |
Collaborator
|
This pull request was successfully merged by @hoxyq in df4d9d1 When will my fix make it into a release? | How to file a pick request? |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#48795 # Changelog: [Internal] Splitting `PerformanceTracer::stopTracingAndCollectEvents()` into 2 separate methods. Once we add logic for starting and stopping tracing on `InstanceAgent`: - We would need to stop tracing everywhere synchronously - Populate data sources in `PerformanceTracer`, like JavaScript samples - Collect all events from different data sources in one payload via `PerformanceTracer::collectEvents()` Reviewed By: huntie Differential Revision: D68331485 fbshipit-source-id: 0d6b21a522d841f7f734e2fad2e0fc533097fdee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Splitting
PerformanceTracer::stopTracingAndCollectEvents()into 2 separate methods.Once we add logic for starting and stopping tracing on
InstanceAgent:PerformanceTracer::collectEvents()Differential Revision: D68331485