Skip to content

VirtualizedList: More Resilient Unit Tests #48819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yungsters wants to merge 1 commit into from
Closed

VirtualizedList: More Resilient Unit Tests #48819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/virtualized-lists/Lists/__tests__/VirtualizedList-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,8 +1526,7 @@ it('adjusts render area with non-zero initialScrollIndex', async () => {
simulateScroll(component, {x: 0, y: 10}); // simulate scroll offset for initialScrollIndex

// TODO: Rewrite test to tolerate subtle timing changes.
performNextBatch();
performNextBatch();
jest.advanceTimersToNextTimer(3);
});

// We should expand the render area after receiving a message indcating we
Expand Down Expand Up @@ -2542,5 +2541,5 @@ function performAllBatches() {
}

function performNextBatch() {
jest.runOnlyPendingTimers();
jest.advanceTimersToNextTimer(1);
}