Set up test to validate refactor of XHR, FileReader and WebSocket classes to use the built-in EventTarget implementation#48930
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
565b91a to
b189e4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
b189e4e to
fafd524
Compare
rubennorte
force-pushed
the
export-D68625226
branch
from
fafd524 to
8f9f15a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
8f9f15a to
1bdd302
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
1bdd302 to
218be6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
218be6b to
d06fdb3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
d06fdb3 to
7c87848
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
7c87848 to
508d1bc
Compare
…in XHR Differential Revision: D68625224
Differential Revision: D68831136
rubennorte
force-pushed
the
export-D68625226
branch
from
508d1bc to
462ae39
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
462ae39 to
66576aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
66576aa to
c5729ac
Compare
…sses to use the built-in EventTarget implementation (facebook#48930) Summary: Pull Request resolved: facebook#48930 Changelog: [internal] This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package. It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test. Differential Revision: D68625226
|
This pull request was exported from Phabricator. Differential Revision: D68625226 |
rubennorte
force-pushed
the
export-D68625226
branch
from
c5729ac to
fb1902a
Compare
|
This pull request has been merged in ea1260a. |
2 participants
Summary:
Changelog: [internal]
This creates new versions of
XMLHttpRequest,FileReaderandWebSocketthat extend the new built-inEventTargetimplementation, instead of the implementation from theevent-target-shimpackage.It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test.
Differential Revision: D68625226