Skip to content

Set up test to validate refactor of XHR, FileReader and WebSocket classes to use the built-in EventTarget implementation #48930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 3 commits into from
Closed

Set up test to validate refactor of XHR, FileReader and WebSocket classes to use the built-in EventTarget implementation #48930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
796a9ee
Refactor NetworkOverlay to use a symbol instead of a public property …
rubennorte Jan 29, 2025
79d65c5
Make some objects read-only in event-related APIs
rubennorte Jan 29, 2025
fb1902a
Set up test to validate refactor of XHR, FileReader and WebSocket cla…
rubennorte Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 8 additions & 174 deletions packages/react-native/Libraries/Blob/FileReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,179 +8,13 @@
* @format
*/

import type Blob from './Blob';
import typeof FileReader from './FileReader_old';

import NativeFileReaderModule from './NativeFileReaderModule';
import {toByteArray} from 'base64-js';
import EventTarget from 'event-target-shim';
// Use a global instead of a flag from ReactNativeFeatureFlags because this will
// be read before apps have a chance to set overrides.
const useBuiltInEventTarget = global.RN$useBuiltInEventTarget?.();

type ReadyState =
| 0 // EMPTY
| 1 // LOADING
| 2; // DONE

type ReaderResult = string | ArrayBuffer;

const READER_EVENTS = [
'abort',
'error',
'load',
'loadstart',
'loadend',
'progress',
];

const EMPTY = 0;
const LOADING = 1;
const DONE = 2;

class FileReader extends (EventTarget(...READER_EVENTS): typeof EventTarget) {
static EMPTY: number = EMPTY;
static LOADING: number = LOADING;
static DONE: number = DONE;

EMPTY: number = EMPTY;
LOADING: number = LOADING;
DONE: number = DONE;

_readyState: ReadyState;
_error: ?Error;
_result: ?ReaderResult;
_aborted: boolean = false;

constructor() {
super();
this._reset();
}

_reset(): void {
this._readyState = EMPTY;
this._error = null;
this._result = null;
}

_setReadyState(newState: ReadyState) {
this._readyState = newState;
this.dispatchEvent({type: 'readystatechange'});
if (newState === DONE) {
if (this._aborted) {
this.dispatchEvent({type: 'abort'});
} else if (this._error) {
this.dispatchEvent({type: 'error'});
} else {
this.dispatchEvent({type: 'load'});
}
this.dispatchEvent({type: 'loadend'});
}
}

readAsArrayBuffer(blob: ?Blob): void {
this._aborted = false;

if (blob == null) {
throw new TypeError(
"Failed to execute 'readAsArrayBuffer' on 'FileReader': parameter 1 is not of type 'Blob'",
);
}

NativeFileReaderModule.readAsDataURL(blob.data).then(
(text: string) => {
if (this._aborted) {
return;
}

const base64 = text.split(',')[1];
const typedArray = toByteArray(base64);

this._result = typedArray.buffer;
this._setReadyState(DONE);
},
error => {
if (this._aborted) {
return;
}
this._error = error;
this._setReadyState(DONE);
},
);
}

readAsDataURL(blob: ?Blob): void {
this._aborted = false;

if (blob == null) {
throw new TypeError(
"Failed to execute 'readAsDataURL' on 'FileReader': parameter 1 is not of type 'Blob'",
);
}

NativeFileReaderModule.readAsDataURL(blob.data).then(
(text: string) => {
if (this._aborted) {
return;
}
this._result = text;
this._setReadyState(DONE);
},
error => {
if (this._aborted) {
return;
}
this._error = error;
this._setReadyState(DONE);
},
);
}

readAsText(blob: ?Blob, encoding: string = 'UTF-8'): void {
this._aborted = false;

if (blob == null) {
throw new TypeError(
"Failed to execute 'readAsText' on 'FileReader': parameter 1 is not of type 'Blob'",
);
}

NativeFileReaderModule.readAsText(blob.data, encoding).then(
(text: string) => {
if (this._aborted) {
return;
}
this._result = text;
this._setReadyState(DONE);
},
error => {
if (this._aborted) {
return;
}
this._error = error;
this._setReadyState(DONE);
},
);
}

abort() {
this._aborted = true;
// only call onreadystatechange if there is something to abort, as per spec
if (this._readyState !== EMPTY && this._readyState !== DONE) {
this._reset();
this._setReadyState(DONE);
}
// Reset again after, in case modified in handler
this._reset();
}

get readyState(): ReadyState {
return this._readyState;
}

get error(): ?Error {
return this._error;
}

get result(): ?ReaderResult {
return this._result;
}
}

export default FileReader;
export default (useBuiltInEventTarget
? // $FlowExpectedError[incompatible-cast]
require('./FileReader_new').default
: require('./FileReader_old').default) as FileReader;
Loading