EZ refactor in ViewManager#49415
Closed
mdvacca wants to merge 2 commits into
Closed
Conversation
…facebook#49414) Summary: In this we are enforcing that that ViewManagers using codegen override getDelegate() method. For now we are logging a softException to get signal from production without crashing the app changelog: [internal] internal Reviewed By: javache Differential Revision: D69621301
Summary: Refactoring NAME -> TAG for consistency with other classes changelog: [internal] internal Reviewed By: Abbondanzo Differential Revision: D69622546
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69622546 |
Contributor
|
This pull request has been merged in b3c41ce. |
Collaborator
|
This pull request was successfully merged by @mdvacca in b3c41ce When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactoring NAME -> TAG for consistency with other classes
changelog: [internal] internal
Reviewed By: Abbondanzo
Differential Revision: D69622546