Skip to content

EZ refactor in ViewManager #49415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 2 commits into from
Closed

EZ refactor in ViewManager #49415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9c7db
Enforce that ViewManagers using codegen override getDelegate() method…
mdvacca Feb 13, 2025
47967df
EZ refactor in ViewManager
mdvacca Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
import com.facebook.react.bridge.BaseJavaModule;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.common.annotations.UnstableReactNativeAPI;
Expand All @@ -40,7 +42,7 @@
public abstract class ViewManager<T extends View, C extends ReactShadowNode>
extends BaseJavaModule {

private static final String NAME = ViewManager.class.getSimpleName();
private static final String TAG = "ViewManager";

private @Nullable ViewManagerDelegate<T> mDelegate = null;

Expand Down Expand Up @@ -113,7 +115,15 @@ public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props)
* view manager should be set via this delegate
*/
protected ViewManagerDelegate<T> getDelegate() {
return new ViewManagerPropertyUpdater.GenericViewManagerDelegate(this);
if (this instanceof ViewManagerWithGeneratedInterface) {
ReactSoftExceptionLogger.logSoftException(
TAG,
new ReactNoCrashSoftException(
"ViewManager using codegen must override getDelegate method (name: "
+ getName()
+ ")."));
}
return new ViewManagerPropertyUpdater.GenericViewManagerDelegate<>(this);
}

private ViewManagerDelegate<T> getOrCreateViewManagerDelegate() {
Expand Down Expand Up @@ -227,12 +237,12 @@ public void onDropViewInstance(@NonNull T view) {
if (viewContext == null) {
// Who knows! Anything is possible. Checking instanceof on null is an NPE,
// So this is not redundant.
FLog.e(NAME, "onDropViewInstance: view [" + view.getId() + "] has a null context");
FLog.e(TAG, "onDropViewInstance: view [" + view.getId() + "] has a null context");
return;
}
if (!(viewContext instanceof ThemedReactContext)) {
FLog.e(
NAME,
TAG,
"onDropViewInstance: view ["
+ view.getId()
+ "] has a context that is not a ThemedReactContext: "
Expand Down