Migrate ReactNativeVersion Android template to Kotlin#49758
Closed
mateoguzmana wants to merge 5 commits into
Closed
Migrate ReactNativeVersion Android template to Kotlin#49758mateoguzmana wants to merge 5 commits into
ReactNativeVersion Android template to Kotlin#49758mateoguzmana wants to merge 5 commits into
Conversation
cortinico
approved these changes
Mar 3, 2025
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
requested changes
Mar 3, 2025
Contributor
cortinico
left a comment
There was a problem hiding this comment.
Could you also delete the /ReactNativeVersion.java-template.js file?
Collaborator
Author
Addressed in e428383 |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 71fbf51. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 71fbf51 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added a new template
ReactNativeVersion.kt-template.jsto be used to generate the Kotlin template for Android. Updating also the set-rn-artifacts-version script to use this template instead of the Java one.Changelog:
[INTERNAL] - Migrate ReactNativeVersion Android template to Kotlin
Test Plan: