Skip to content

Migrate ReactNativeVersion Android template to Kotlin#49758

Closed
mateoguzmana wants to merge 5 commits into
facebook:mainfrom
mateoguzmana:refactor/migrate-react-native-version
Closed

Migrate ReactNativeVersion Android template to Kotlin#49758
mateoguzmana wants to merge 5 commits into
facebook:mainfrom
mateoguzmana:refactor/migrate-react-native-version

Conversation

@mateoguzmana
Copy link
Copy Markdown
Collaborator

Summary:

Added a new template ReactNativeVersion.kt-template.js to be used to generate the Kotlin template for Android. Updating also the set-rn-artifacts-version script to use this template instead of the Java one.

Changelog:

[INTERNAL] - Migrate ReactNativeVersion Android template to Kotlin

Test Plan:

yarn test-android
yarn android
node ./scripts/releases/set-version.js 1000.0.0

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 1, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also delete the /ReactNativeVersion.java-template.js file?

@mateoguzmana
Copy link
Copy Markdown
Collaborator Author

Could you also delete the /ReactNativeVersion.java-template.js file?

Addressed in e428383

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 4, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 71fbf51.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @mateoguzmana in 71fbf51

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants