Skip to content

Migrate ReactNativeVersion Android template to Kotlin #49758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 5 commits into from
Closed

Migrate ReactNativeVersion Android template to Kotlin #49758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ca5dce
Migrate ReactNativeVersion to Kotlin
mateoguzmana Mar 1, 2025
cfaba3c
Merge branch 'main' of github.com:mateoguzmana/react-native into refa…
mateoguzmana Mar 1, 2025
418235b
Use non-mutable map to keep it inline with the Java template
mateoguzmana Mar 1, 2025
b3c8528
Add @JvmField to maintain backwards compatibility with Java consumers
mateoguzmana Mar 1, 2025
e428383
Delete ReactNativeVersion.java-template.js
mateoguzmana Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .../ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions ...ve/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated by scripts/releases/set-version.js
*/

package com.facebook.react.modules.systeminfo

public object ReactNativeVersion {
@JvmField
public val VERSION: Map<String, Any?> = mapOf(
"major" to 1000,
"minor" to 0,
"patch" to 0,
"prerelease" to null
)
}
44 changes: 20 additions & 24 deletions scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ exports[`updateReactNativeArtifacts should set nightly version: packages/react-n
"
`;

exports[`updateReactNativeArtifacts should set nightly version: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java 1`] = `
exports[`updateReactNativeArtifacts should set nightly version: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `
"/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
Expand All @@ -75,18 +75,16 @@ exports[`updateReactNativeArtifacts should set nightly version: packages/react-n
* << GENERATED >>
*/

package com.facebook.react.modules.systeminfo;
package com.facebook.react.modules.systeminfo

import com.facebook.react.common.MapBuilder;

import java.util.Map;

public class ReactNativeVersion {
public static final Map<String, Object> VERSION = MapBuilder.<String, Object>of(
\\"major\\", 0,
\\"minor\\", 81,
\\"patch\\", 0,
\\"prerelease\\", \\"nightly-29282302-abcd1234\\");
public object ReactNativeVersion {
@JvmField
public val VERSION: Map<String, Any?> = mapOf(
\\"major\\" to 0,
\\"minor\\" to 81,
\\"patch\\" to 0,
\\"prerelease\\" to \\"nightly-29282302-abcd1234\\"
)
}
"
`;
Expand Down Expand Up @@ -188,7 +186,7 @@ exports[`updateReactNativeArtifacts should set release version: packages/react-n
"
`;

exports[`updateReactNativeArtifacts should set release version: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java 1`] = `
exports[`updateReactNativeArtifacts should set release version: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `
"/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
Expand All @@ -198,18 +196,16 @@ exports[`updateReactNativeArtifacts should set release version: packages/react-n
* << GENERATED >>
*/

package com.facebook.react.modules.systeminfo;

import com.facebook.react.common.MapBuilder;

import java.util.Map;
package com.facebook.react.modules.systeminfo

public class ReactNativeVersion {
public static final Map<String, Object> VERSION = MapBuilder.<String, Object>of(
\\"major\\", 0,
\\"minor\\", 81,
\\"patch\\", 0,
\\"prerelease\\", null);
public object ReactNativeVersion {
@JvmField
public val VERSION: Map<String, Any?> = mapOf(
\\"major\\" to 0,
\\"minor\\" to 81,
\\"patch\\" to 0,
\\"prerelease\\" to null
)
}
"
`;
Expand Down
6 changes: 3 additions & 3 deletions scripts/releases/__tests__/__snapshots__/set-version-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ exports[`setVersion updates monorepo for nightly: set-version/packages/react-nat

exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactAndroid/gradle.properties 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java 1`] = `"[omitted]"`;
exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for nightly: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;

Expand Down Expand Up @@ -142,7 +142,7 @@ exports[`setVersion updates monorepo for release-candidate: set-version/packages

exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactAndroid/gradle.properties 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java 1`] = `"[omitted]"`;
exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for release-candidate: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;

Expand Down Expand Up @@ -223,7 +223,7 @@ exports[`setVersion updates monorepo for stable version: set-version/packages/re

exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactAndroid/gradle.properties 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java 1`] = `"[omitted]"`;
exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt 1`] = `"[omitted]"`;

exports[`setVersion updates monorepo for stable version: set-version/packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h 1`] = `"[omitted]"`;

Expand Down
4 changes: 2 additions & 2 deletions scripts/releases/set-rn-artifacts-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ function updateSourceFiles(
fs.writeFile(
path.join(
REPO_ROOT,
'packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java',
'packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.kt',
),
require('./templates/ReactNativeVersion.java-template')(templateData),
require('./templates/ReactNativeVersion.kt-template')(templateData),
),
fs.writeFile(
path.join(REPO_ROOT, 'packages/react-native/React/Base/RCTVersion.m'),
Expand Down
24 changes: 11 additions & 13 deletions ...lates/ReactNativeVersion.java-template.js → ...mplates/ReactNativeVersion.kt-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,17 @@ module.exports = ({version} /*: {version: Version} */) /*: string */ => `/**
* ${'@'}generated by scripts/releases/set-version.js
*/

package com.facebook.react.modules.systeminfo;
package com.facebook.react.modules.systeminfo

import com.facebook.react.common.MapBuilder;

import java.util.Map;

public class ReactNativeVersion {
public static final Map<String, Object> VERSION = MapBuilder.<String, Object>of(
"major", ${version.major},
"minor", ${version.minor},
"patch", ${version.patch},
"prerelease", ${
version.prerelease != null ? `"${version.prerelease}"` : 'null'
});
public object ReactNativeVersion {
@JvmField
public val VERSION: Map<String, Any?> = mapOf(
"major" to ${version.major},
"minor" to ${version.minor},
"patch" to ${version.patch},
"prerelease" to ${
version.prerelease != null ? `"${version.prerelease}"` : 'null'
}
)
}
`;