Migrate all imports from react-native to package imports instead of relative in Fantom tests#49912
Closed
rubennorte wants to merge 2 commits into
Closed
Migrate all imports from react-native to package imports instead of relative in Fantom tests#49912rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779722 |
rubennorte
force-pushed
the
export-D70779722
branch
from
34ff4ab to
e526071
Compare
rubennorte
force-pushed
the
export-D70779722
branch
from
e526071 to
bf284a2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779722 |
rubennorte
force-pushed
the
export-D70779722
branch
from
bf284a2 to
5ea089d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779722 |
rubennorte
force-pushed
the
export-D70779722
branch
from
5ea089d to
499e84e
Compare
rubennorte
force-pushed
the
export-D70779722
branch
from
499e84e to
d2c311e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779722 |
rubennorte
force-pushed
the
export-D70779722
branch
from
d2c311e to
6712e4c
Compare
Summary: Changelog: [internal] The approach in Fantom tests is to use the public API as much as we can, but forcing us to use relative imports in tests makes it harder to see what's the public API and what's not. This disables the lint rule so we can use package imports in Fantom tests without warnings/errors. Reviewed By: sammy-SC Differential Revision: D70779721
…elative in Fantom tests (facebook#49912) Summary: Changelog: [internal] This migrates all Fantom tests to use package-relative imports from `react-native` instead of relative paths. Note that a lot of the current deep imports (e.g.: `import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement'`) will not be necessary when we release those APIs as public. Reviewed By: sammy-SC Differential Revision: D70779722
rubennorte
force-pushed
the
export-D70779722
branch
from
6712e4c to
29c60cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779722 |
Contributor
|
This pull request has been merged in 7cff19b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This migrates all Fantom tests to use package-relative imports from
react-nativeinstead of relative paths.Note that a lot of the current deep imports (e.g.:
import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement') will not be necessary when we release those APIs as public.Differential Revision: D70779722