feat(iOS): allow eager initialization of RCTRootViewFactory#49986
Closed
mdjastrzebski wants to merge 5 commits into
Closed
feat(iOS): allow eager initialization of RCTRootViewFactory#49986mdjastrzebski wants to merge 5 commits into
mdjastrzebski wants to merge 5 commits into
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Mar 12, 2025
Comment on lines
+137
to
+147
| if (_configuration.bridgelessEnabled) { | ||
| // Enable TurboModule interop by default in Bridgeless mode | ||
| RCTEnableTurboModuleInterop(YES); | ||
| RCTEnableTurboModuleInteropBridgeProxy(YES); | ||
|
|
||
| [self createReactHostIfNeeded:launchOptions]; | ||
| } | ||
|
|
||
| [self createBridgeIfNeeded:launchOptions]; | ||
| [self createBridgeAdapterIfNeeded]; | ||
| } |
Contributor
There was a problem hiding this comment.
is almost identical to the code in the viewWithModuleName:initialProperties:launchOptions:. Can we avoid code duplication and find a way to reuse it?
cipolleschi
approved these changes
Mar 20, 2025
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in ddbb5fd. |
Collaborator
|
This pull request was successfully merged by @mdjastrzebski in ddbb5fd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Expose eager initialization method on
RCTRootViewFactory(iOS) so that application can prepareReactHost/Bridge before actually creating a root view. Then creating a root view is significantly faster.Changelog:
[IOS] [ADDED] - allow eager initialization of
RCTRootViewFactoryTest Plan:
Invoke
initializeReactHostWithLaunchOptions:before callingviewWithModuleName:and measure the time difference vs not using eager initilization:Before
viewWithModuleName:: 63.39ms, 47.91 ms, 60.18msAfter:
initializeReactHostWithLaunchOptions: 52.41 ms, 81.03 ms, 60.52 msviewWithModuleName: 0.49 ms, 0.63 ms, 0.47 msTest run 3 times on iPhone simulator on M1 mac.