Skip to content

feat(iOS): allow eager initialization of RCTRootViewFactory #49986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdjastrzebski wants to merge 5 commits into from
Closed

feat(iOS): allow eager initialization of RCTRootViewFactory #49986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1da7e2b
feat(iOS): RCTRootViewEager init
mdjastrzebski Mar 12, 2025
4d5bad0
code review changes
mdjastrzebski Mar 12, 2025
c8d57cc
fix
mdjastrzebski Mar 12, 2025
e2c2675
tweaks
mdjastrzebski Mar 12, 2025
751f676
.
mdjastrzebski Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,15 @@ typedef void (^RCTLoadSourceForBridgeBlock)(RCTBridge *bridge, RCTSourceLoadBloc

#pragma mark - RCTRootViewFactory Helpers

/**
* Initialize React Host/Bridge without creating a view.
*
* Use it to speed up later viewWithModuleName: calls.
*
* @parameter: launchOptions - a dictionary with a set of options.
*/
- (void)initializeReactHostWithLaunchOptions:(NSDictionary *__nullable)launchOptions;

- (RCTHost *)createReactHost:(NSDictionary *__nullable)launchOptions;

@end
Expand Down
20 changes: 14 additions & 6 deletions packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,17 +132,28 @@ - (UIView *)viewWithModuleName:(NSString *)moduleName
return [self viewWithModuleName:moduleName initialProperties:nil launchOptions:nil];
}

- (UIView *)viewWithModuleName:(NSString *)moduleName
initialProperties:(NSDictionary *)initProps
launchOptions:(NSDictionary *)launchOptions
- (void)initializeReactHostWithLaunchOptions:(NSDictionary *)launchOptions
{
if (_configuration.bridgelessEnabled) {
// Enable TurboModule interop by default in Bridgeless mode
RCTEnableTurboModuleInterop(YES);
RCTEnableTurboModuleInteropBridgeProxy(YES);

[self createReactHostIfNeeded:launchOptions];
return;
}

[self createBridgeIfNeeded:launchOptions];
[self createBridgeAdapterIfNeeded];
}

- (UIView *)viewWithModuleName:(NSString *)moduleName
initialProperties:(NSDictionary *)initProps
launchOptions:(NSDictionary *)launchOptions
{
[self initializeReactHostWithLaunchOptions:launchOptions];

if (_configuration.bridgelessEnabled) {
RCTFabricSurface *surface = [self.reactHost createSurfaceWithModuleName:moduleName initialProperties:initProps];

RCTSurfaceHostingProxyRootView *surfaceHostingProxyRootView =
Expand All @@ -155,9 +166,6 @@ - (UIView *)viewWithModuleName:(NSString *)moduleName
return surfaceHostingProxyRootView;
}

[self createBridgeIfNeeded:launchOptions];
[self createBridgeAdapterIfNeeded];

UIView *rootView;
if (_configuration.createRootViewWithBridge != nil) {
rootView = _configuration.createRootViewWithBridge(self.bridge, moduleName, initProps);
Expand Down