Add warning when a module tries to invoke a method using the interop layer#50175
Closed
cipolleschi wants to merge 2 commits into
Closed
Add warning when a module tries to invoke a method using the interop layer#50175cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
Summary: Pull Request resolved: facebook#49897 This change introduces the first warning for the New Architecture warning. When modules are registered through the RCT_EXPORT_MODULE (or its variants) a warning is emitted. Note: currently it is only emitted on the Xcode console. I'm looking into ways to emit it also in the RN DevTools console. ## Changelog: [iOS][Added] - Show warnings in the New Architecture when modules are loaded using RCT_EXPORT_MODULE Differential Revision: D70789672
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71561348 |
cipolleschi
force-pushed
the
export-D71561348
branch
from
ff50d51 to
1f93b6c
Compare
…layer (facebook#50175) Summary: Pull Request resolved: facebook#50175 This change logs warning in the RN Dev Tools and in the Xcode console when a legacy module is used through the interop layer. The `moduleName.methodName` warning is logged only once per usage not to flood the users with Warnings. ## Changelog: [iOS][Added] - Add warnings when a legacy module is used in the Interop Layer. Reviewed By: cortinico Differential Revision: D71561348
cipolleschi
force-pushed
the
export-D71561348
branch
from
1f93b6c to
b27d909
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71561348 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71561348 |
cipolleschi
force-pushed
the
export-D71561348
branch
from
b27d909 to
93c657f
Compare
Contributor
|
This pull request has been merged in 7b500b8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change logs warning in the RN Dev Tools and in the Xcode console when a legacy module is used through the interop layer.
The
moduleName.methodNamewarning is logged only once per usage not to flood the users with Warnings.Changelog:
[iOS][Added] - Add warnings when a legacy module is used in the Interop Layer.
Differential Revision: D71561348