Ensure interop is disabled when ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true#50604
Closed
mdvacca wants to merge 2 commits into
Closed
Ensure interop is disabled when ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true#50604mdvacca wants to merge 2 commits into
mdvacca wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
2f2d93a to
49834ce
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
49834ce to
a6b4ae3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
a6b4ae3 to
90695f7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
90695f7 to
f95724c
Compare
mdvacca
force-pushed
the
export-D71854550
branch
from
f95724c to
ae8de52
Compare
mdvacca
force-pushed
the
export-D71854550
branch
from
ae8de52 to
9550a29
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
9550a29 to
07e18f8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
Summary: Mark ReactPackageLogger as LegacyArchitecture changelog: [internal] internal Differential Revision: D72067076
…FY_LEGACY_ARCHITECTURE == true (facebook#50604) Summary: Pull Request resolved: facebook#50604 ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE asume Fabric and TurboModule interops are disabled, in this diff I'm adding an assertion to validate this at runtime changelog: [internal] internal Reviewed By: mlord93 Differential Revision: D71854550
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71854550 |
mdvacca
force-pushed
the
export-D71854550
branch
from
07e18f8 to
1562fab
Compare
Contributor
|
This pull request has been merged in 7aed1fe. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…FY_LEGACY_ARCHITECTURE == true (facebook#50604) Summary: Pull Request resolved: facebook#50604 ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE asume Fabric and TurboModule interops are disabled, in this diff I'm adding an assertion to validate this at runtime changelog: [internal] internal Reviewed By: mlord93 Differential Revision: D71854550 fbshipit-source-id: a4b3acfe4c3227115300b100be4d6222d5eace8e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE asume Fabric and TurboModule interops are disabled, in this diff I'm adding an assertion to validate this at runtime
changelog: [internal] internal
Reviewed By: mlord93
Differential Revision: D71854550