Skip to content

Ensure interop is disabled when ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true #50604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 2 commits into from
Closed

Ensure interop is disabled when ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true #50604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b532b98
Mark ReactPackageLogger as @LegacyArchitecture
mdvacca Apr 10, 2025
1562fab
Ensure interop is disabled when ReactBuildConfig.UNSTABLE_ENABLE_MINI…
mdvacca Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@

package com.facebook.react

import com.facebook.react.common.annotations.internal.LegacyArchitecture

/** Interface for the bridge to call for TTI start and end markers. */
@LegacyArchitecture
internal interface ReactPackageLogger {
fun startProcessPackage(): Unit

Expand Down
10 changes: 10 additions & 0 deletions ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,16 @@ private Task<Void> getOrCreateStartTask() {
ReactNativeFeatureFlags.useTurboModules(),
"useTurboModules FeatureFlag must be set to start ReactNative.");
}
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {
Assertions.assertCondition(
!ReactNativeFeatureFlags.useFabricInterop(),
"useFabricInterop FeatureFlag must be false when"
+ " UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true.");
Assertions.assertCondition(
!ReactNativeFeatureFlags.useTurboModuleInterop(),
"useTurboModuleInterop FeatureFlag must be false when"
+ " UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE == true.");
}
mStartTask =
waitThenCallGetOrCreateReactInstanceTask()
.continueWithTask(
Expand Down