Let LinkMovementMethod take precedence over accessibility delegate when dataDetector is present#50887
Closed
joevilches wants to merge 1 commit intofacebook:mainfrom
Closed
Let LinkMovementMethod take precedence over accessibility delegate when dataDetector is present#50887joevilches wants to merge 1 commit intofacebook:mainfrom
joevilches wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73549839 |
joevilches
force-pushed
the
export-D73549839
branch
from
339dddd to
6008281
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73549839 |
joevilches
force-pushed
the
export-D73549839
branch
from
6008281 to
619842a
Compare
joevilches
force-pushed
the
export-D73549839
branch
from
619842a to
96eab87
Compare
…en dataDetector is present (facebook#50887) Summary: Pull Request resolved: facebook#50887 There is currently a bug with the recent changes to keyboard accessibility with Text and nested links. If something with nested links has a `dataDetectorType` prop then we have 2 different selections when we navigate with arrow keys since the drawing behind the 2 are separate. Removing LinkMovementMethod is not possible since it allows for clicking the links it detects As a result, lets just allow it to take precedence over the delegate when handling link navigation in the cases its present. Changelog: [Android][Fixed] - Double selection with dataDetectorType and links Reviewed By: NickGerleman Differential Revision: D73549839
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73549839 |
joevilches
force-pushed
the
export-D73549839
branch
from
96eab87 to
31e1921
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 30, 2025
…en dataDetector is present (facebook#50887) Summary: There is currently a bug with the recent changes to keyboard accessibility with Text and nested links. If something with nested links has a `dataDetectorType` prop then we have 2 different selections when we navigate with arrow keys since the drawing behind the 2 are separate. Removing LinkMovementMethod is not possible since it allows for clicking the links it detects As a result, lets just allow it to take precedence over the delegate when handling link navigation in the cases its present. Changelog: [Android][Fixed] - Double selection with dataDetectorType and links Reviewed By: NickGerleman Differential Revision: D73549839
Contributor
|
This pull request has been merged in 70aced5. |
Collaborator
|
This pull request was successfully merged by @joevilches in 70aced5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There is currently a bug with the recent changes to keyboard accessibility with Text and nested links. If something with nested links has a
dataDetectorTypeprop then we have 2 different selections when we navigate with arrow keys since the drawing behind the 2 are separate.Removing LinkMovementMethod is not possible since it allows for clicking the links it detects
As a result, lets just allow it to take precedence over the delegate when handling link navigation in the cases its present.
Changelog: [Android][Fixed] - Double selection with dataDetectorType and links
Differential Revision: D73549839