Skip to content

Let LinkMovementMethod take precedence over accessibility delegate when dataDetector is present #50887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joevilches wants to merge 1 commit into from
Closed

Let LinkMovementMethod take precedence over accessibility delegate when dataDetector is present #50887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .../react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,14 +734,23 @@ protected boolean dispatchHoverEvent(MotionEvent event) {
return super.dispatchHoverEvent(event);
}

/**
* Note that if we have a movement method then we DO NOT forward these events to the accessibility
* delegate. This is because the movement method should handle the focus highlighting and
* changing. If we don't do this then we have mutliple selections happening at once. We cannot get
* rid of movement method since links found by Linkify will not be clickable. Also, putting this
* gating in the accessibility delegate itself will break screen reader accessibility more
* generally, since we still need to register virtual views.
*/
@Override
public final void onFocusChanged(
boolean gainFocus, int direction, @Nullable Rect previouslyFocusedRect) {
super.onFocusChanged(gainFocus, direction, previouslyFocusedRect);
AccessibilityDelegateCompat accessibilityDelegateCompat =
ViewCompat.getAccessibilityDelegate(this);
if (accessibilityDelegateCompat != null
&& accessibilityDelegateCompat instanceof ReactTextViewAccessibilityDelegate) {
&& accessibilityDelegateCompat instanceof ReactTextViewAccessibilityDelegate
&& getMovementMethod() == null) {
((ReactTextViewAccessibilityDelegate) accessibilityDelegateCompat)
.onFocusChanged(gainFocus, direction, previouslyFocusedRect);
}
Expand All @@ -752,6 +761,7 @@ public boolean dispatchKeyEvent(KeyEvent event) {
AccessibilityDelegateCompat accessibilityDelegateCompat =
ViewCompat.getAccessibilityDelegate(this);
return (accessibilityDelegateCompat != null
&& getMovementMethod() == null
&& accessibilityDelegateCompat instanceof ReactTextViewAccessibilityDelegate
&& ((ReactTextViewAccessibilityDelegate) accessibilityDelegateCompat)
.dispatchKeyEvent(event))
Expand Down
Loading