Add support to diff ImageSource props#51643
Closed
mdvacca wants to merge 8 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
2 similar comments
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Differential Revision: D69487496
Summary: Extend getDiffProps method to call HostPlatformViewProps changelog: [internal] internal Differential Revision: D69487495
Summary: Extend getDiffProps method to support no changes of props changelog: [internal] internal Differential Revision: D69487497
Summary: Add support for diffing primitve type props changelog: [internal] internal Differential Revision: D69491368
Summary: Add support for diffing ColorPrimitive props changelog: [internal] internal Differential Revision: D69493546
Differential Revision: D75469453
Differential Revision: D75469451
Summary: Pull Request resolved: facebook#51643 Add support to diff ImageSource props /react-native/ReactCommon/react/renderer/imagemanager/primitives.h changelog: [internal] internal Reviewed By: javache Differential Revision: D69497848
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69497848 |
Contributor
|
This pull request has been merged in da5d15b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add support to diff ImageSource props
/react-native/ReactCommon/react/renderer/imagemanager/primitives.h
changelog: [internal] internal
Reviewed By: javache
Differential Revision: D69497848