Skip to content

Add support to diff ImageSource props #51643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 8 commits into from
Closed

Add support to diff ImageSource props #51643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9d34b4
Prototype to create getDiff method using codegen
mdvacca May 27, 2025
ed6da6d
Extend getDiffProps method to call HostPlatformViewProps
mdvacca May 27, 2025
2c75903
Extend getDiffProps method to support no changes of props
mdvacca May 27, 2025
32c99bd
Add support for diffing primitve type props
mdvacca May 27, 2025
39ebc6c
Add support for diffing ColorPrimitive props
mdvacca May 27, 2025
5a2dc53
Assert ImageRequest is not used as a prop in codegene
mdvacca May 27, 2025
bbc2fa1
Add support to diff Point props
mdvacca May 27, 2025
4917cf6
Add support to diff ImageSource props (#51643)
mdvacca May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
444 changes: 410 additions & 34 deletions ...codegen/e2e/deep_imports/__tests__/components/__snapshots__/GeneratePropsCpp-test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

72 changes: 72 additions & 0 deletions ...e-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GeneratePropsH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ class ArrayPropsNativeComponentViewProps final : public ViewProps {
std::vector<ArrayPropsNativeComponentViewObjectStruct> object{};
std::vector<ArrayPropsNativeComponentViewArrayOfObjectsStruct> arrayOfObjects{};
std::vector<folly::dynamic> arrayOfMixed{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -197,6 +201,10 @@ class BooleanPropNativeComponentViewProps final : public ViewProps {

bool disabled{false};
bool disabledNullable{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -231,6 +239,10 @@ class ColorPropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

SharedColor tintColor{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -265,6 +277,10 @@ class DimensionPropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

YGValue marginBack{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -298,6 +314,10 @@ class EdgeInsetsPropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props



#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -380,6 +400,10 @@ class EnumPropNativeComponentViewProps final : public ViewProps {

EnumPropNativeComponentViewAlignment alignment{EnumPropNativeComponentViewAlignment::Center};
EnumPropNativeComponentViewIntervals intervals{EnumPropNativeComponentViewIntervals::Intervals0};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -413,6 +437,10 @@ class EventNestedObjectPropsNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

bool disabled{false};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -446,6 +474,10 @@ class EventPropsNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

bool disabled{false};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -485,6 +517,10 @@ class FloatPropsNativeComponentViewProps final : public ViewProps {
Float blurRadius5{1.0};
Float blurRadius6{0.0};
Float blurRadiusNullable{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -519,6 +555,10 @@ class ImagePropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

ImageSource thumbImage{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -554,6 +594,10 @@ class IntegerPropNativeComponentViewProps final : public ViewProps {
int progress1{0};
int progress2{-1};
int progress3{10};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -587,6 +631,10 @@ class InterfaceOnlyNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

std::string title{\\"\\"};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -620,6 +668,10 @@ class MixedPropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

folly::dynamic mixedProp{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -659,6 +711,10 @@ class MultiNativePropNativeComponentViewProps final : public ViewProps {
SharedColor color{};
SharedColor thumbTintColor{};
Point point{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -692,6 +748,10 @@ class NoPropsNoEventsNativeComponentViewProps final : public ViewProps {
#pragma mark - Props



#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -855,6 +915,10 @@ class ObjectPropsNativeComponentProps final : public ViewProps {
ObjectPropsNativeComponentObjectPropStruct objectProp{};
ObjectPropsNativeComponentObjectArrayPropStruct objectArrayProp{};
ObjectPropsNativeComponentObjectPrimitiveRequiredPropStruct objectPrimitiveRequiredProp{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -889,6 +953,10 @@ class PointPropNativeComponentViewProps final : public ViewProps {
#pragma mark - Props

Point startPoint{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down Expand Up @@ -923,6 +991,10 @@ class StringPropNativeComponentViewProps final : public ViewProps {

std::string placeholder{\\"\\"};
std::string defaultValue{};

#ifdef RN_SERIALIZABLE_STATE
folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif
};

} // namespace facebook::react
Expand Down
Loading
Loading