Add a method for transfering an ownership of captured TraceEvents#52940
Closed
hoxyq wants to merge 5 commits into
Closed
Add a method for transfering an ownership of captured TraceEvents#52940hoxyq wants to merge 5 commits into
hoxyq wants to merge 5 commits into
Conversation
Summary: # Changelog: [Internal] We can't rely on RuntimeExecutor to actually tell us what JavaScript thread number is. Although this would work correct in most of the cases, this is not the solution we should go with. Instead, we should fetch a map <id, name> of threads from the Host. This is what we will lazily call at the start of the Trace. I will add later on top of the stack. Reviewed By: rubennorte Differential Revision: D78990872
Summary: # Changelog: [Internal] This removes the use of `PerformanceTracer` instance in a serialization logic. Reviewed By: rubennorte Differential Revision: D78919220
Summary: # Changelog: [Internal] Align with other serializers in `jsinspector-modern` to have just static public method. Reviewed By: rubennorte Differential Revision: D79131985
Summary: # Changelog: [Internal] This is required for storing these Trace Events somewhere outside of PerformanceTracer, in case these events will be dispatched later. Reviewed By: rubennorte Differential Revision: D78741192
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78741192 |
Contributor
|
This pull request has been merged in 2c540ac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is required for storing these Trace Events somewhere outside of PerformanceTracer, in case these events will be dispatched later.
Reviewed By: rubennorte
Differential Revision: D78741192