Make observer go through Fanton.runTask in LongTasksAPI test#52948
Closed
rubennorte wants to merge 1 commit into
Closed
Make observer go through Fanton.runTask in LongTasksAPI test#52948rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: Changelog: [internal] Not sure why this test is flaky, but this tries to add some more assertions to see where the problem comes from. Differential Revision: D79366370
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79366370 |
Contributor
|
This pull request has been merged in 384fc54. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 384fc54 When will my fix make it into a release? | How to file a pick request? |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Aug 1, 2025
Summary: Changelog: [internal] The test for LongTasks is flaky on Github and I made a change to figure out why (D79366370 / facebook#52948). It seems that the long task happens before the artificial task we're using for testing, so we can update the test to filter those out. Differential Revision: D79441987
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: #52974 Changelog: [internal] The test for LongTasks is flaky on Github and I made a change to figure out why (D79366370 / #52948). It seems that the long task happens before the artificial task we're using for testing, so we can update the test to filter those out. Reviewed By: cortinico Differential Revision: D79441987 fbshipit-source-id: 99296d704cfec2e61ca29d06878df171231f4e78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Not sure why this test is flaky, but this tries to add some more assertions to see where the problem comes from.
Differential Revision: D79366370