Skip to content

Make observer go through Fanton.runTask in LongTasksAPI test #52948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Make observer go through Fanton.runTask in LongTasksAPI test #52948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions packages/react-native/src/private/webapis/performance/__tests__/LongTasksAPI-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ describe('LongTasks API', () => {
it('does NOT report short tasks (under 50ms)', () => {
const callback = jest.fn();

observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
Fantom.runTask(() => {
observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
});

expect(callback).not.toHaveBeenCalled();

Fantom.runTask(() => {
// Short task.
Expand All @@ -75,8 +79,12 @@ describe('LongTasks API', () => {
it('reports long tasks (over 50ms)', () => {
const callback = jest.fn();

observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
Fantom.runTask(() => {
observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
});

expect(callback).not.toHaveBeenCalled();

const beforeTaskStartTime = performance.now();
let afterTaskStartTime;
Expand Down Expand Up @@ -122,8 +130,12 @@ describe('LongTasks API', () => {
it('should NOT be reported if they are longer than 50ms but had yielding opportunities in intervals shorter than 50ms', () => {
const callback = jest.fn();

observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
Fantom.runTask(() => {
observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
});

expect(callback).not.toHaveBeenCalled();

const shouldYield = global.nativeRuntimeScheduler.unstable_shouldYield;

Expand All @@ -141,8 +153,12 @@ describe('LongTasks API', () => {
it('should be reported if running for longer than 50ms between yielding opportunities', () => {
const callback = jest.fn();

observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
Fantom.runTask(() => {
observer = new PerformanceObserver(callback);
observer.observe({entryTypes: ['longtask']});
});

expect(callback).not.toHaveBeenCalled();

const shouldYield = global.nativeRuntimeScheduler.unstable_shouldYield;

Expand Down
Loading