Pin Node.js version in GitHub Actions to 24.4.1#53013
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Pin Node.js version in GitHub Actions to 24.4.1#53013huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Quick fix to restore CI on `main`. `actions/setup-node` is now pulling Node.js `24.5.0`, which introduces a bug affecting `packages/dev-middleware/src/__tests__/` Jest tests. Changelog: [Internal] Differential Revision: D79551277
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79551277 |
Contributor
|
This pull request has been merged in bbcafbb. |
Collaborator
|
This pull request was successfully merged by @huntie in bbcafbb When will my fix make it into a release? | How to file a pick request? |
vzaidman
pushed a commit
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: #53013 Quick fix to restore CI on `main`. `actions/setup-node` is now pulling Node.js `24.5.0`, which introduces a bug affecting `packages/dev-middleware/src/__tests__/` Jest tests. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D79551277 fbshipit-source-id: 51951ad8ffe376a478da268b50aa54ac2d9bba03
Collaborator
|
This pull request was successfully merged by @huntie in aac7dbe When will my fix make it into a release? | How to file a pick request? |
robhogan
added a commit
that referenced
this pull request
Nov 21, 2025
…y, restore CI Summary: CI fails after attempting to update to Node v24 (latest LTS) because our `dev-middleware` dev-only dependency `selfsigned` uses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of: ``` error:0A00018F:SSL routines::ee key too small ``` This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013 This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above. Changelog: [Internal] Differential Revision: D87643898
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
…y, restore CI (#54634) Summary: CI fails after attempting to update to Node v24 (latest LTS) because our `dev-middleware` dev-only dependency `selfsigned` uses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of: ``` error:0A00018F:SSL routines::ee key too small ``` This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013 This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D87643898
meta-codesync bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
…y, restore CI (#54634) Summary: Pull Request resolved: #54634 CI fails after attempting to update to Node v24 (latest LTS) because our `dev-middleware` dev-only dependency `selfsigned` uses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of: ``` error:0A00018F:SSL routines::ee key too small ``` This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013 This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D87643898 fbshipit-source-id: f1072c0801769d5fcd4bb53f68999653c6dad29f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Quick fix to restore CI on
main.actions/setup-nodeis now pulling Node.js24.5.0, which introduces a bug affectingpackages/dev-middleware/src/__tests__/Jest tests.Changelog: [Internal]
Differential Revision: D79551277