Update dev dependency selfsigned to v4, fix Node >=v24.5 compatibility, restore CI#54634
Closed
Update dev dependency selfsigned to v4, fix Node >=v24.5 compatibility, restore CI#54634
Conversation
meta-cla
bot
added
the
CLA Signed
…y, restore CI (#54634) Summary: CI fails after attempting to update to Node v24 (latest LTS) because our `dev-middleware` dev-only dependency `selfsigned` uses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of: ``` error:0A00018F:SSL routines::ee key too small ``` This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013 This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D87643898
facebook-github-bot
force-pushed
the
export-D87643898
branch
from
3dd26f9 to
90a2454
Compare
|
This pull request has been merged in f3f7e17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CI fails after attempting to update to Node v24 (latest LTS) because our
dev-middlewaredev-only dependencyselfsigneduses a default key size incompatible with the version of OpenSSL in Node>=24.5. We see lots of:This was mitigated in OSS CI by pinning our Node tests to before v24.5: #53013
This default is raised upstream in jfromaniello/selfsigned@bf687c8 , this bumps to v4 which includes that fix, and removes the temporary mitigation above.
Changelog:
[Internal]
Differential Revision: D87643898