Add basic test for Modal#53140
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
cipolleschi
force-pushed
the
export-D79805808
branch
from
ea19c24 to
eb516ea
Compare
cipolleschi
force-pushed
the
export-D79805808
branch
from
eb516ea to
8b1ac12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
cipolleschi
force-pushed
the
export-D79805808
branch
2 times, most recently
from
dc8151e to
bf8dcc0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
cipolleschi
force-pushed
the
export-D79805808
branch
from
bf8dcc0 to
d84e9c1
Compare
cipolleschi
force-pushed
the
export-D79805808
branch
from
d84e9c1 to
96742cf
Compare
cipolleschi
force-pushed
the
export-D79805808
branch
from
96742cf to
c6b73e0
Compare
cipolleschi
force-pushed
the
export-D79805808
branch
from
c6b73e0 to
09c9f7e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
cipolleschi
force-pushed
the
export-D79805808
branch
2 times, most recently
from
e1d2e26 to
7476c38
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
Summary: Pull Request resolved: facebook#53135 Our Codegenerated components are not generating code for `getDebugProps`. This change modifies Codegen to add those functions for all the codegen components. ## Changelog: [General][Added] - Added getDebugProps to codegen ## Facebook: `getDebugProps` are required by Fantom to write tests. However, we can't generate these function for third party components, because codegen can generate arbitrary structs and we don't have a generic `toString()` method that can be used or automatically generated by C++. By generating this function only for Core Components, we can ensure that we can write Fantom tests without breaking all the users of React Native. Differential Revision: D79805145 Reviewed By: rubennorte
cipolleschi
force-pushed
the
export-D79805808
branch
from
7476c38 to
0e87c63
Compare
Summary: Pull Request resolved: facebook#53140 As per title, this change adds the boilerplate code for a Fantom test on Modal ## Changelog: [Internal] - Reviewed By: andrewdacenko Differential Revision: D79805808
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: facebook#53140 As per title, this change adds the boilerplate code for a Fantom test on Modal ## Changelog: [Internal] - Differential Revision: D79805808 Reviewed By: andrewdacenko
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79805808 |
cipolleschi
force-pushed
the
export-D79805808
branch
from
0e87c63 to
b775076
Compare
Contributor
|
This pull request has been merged in 7035391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As per title, this change adds the boilerplate code for a Fantom test on Modal
Changelog:
[Internal] -
Differential Revision: D79805808