Skip to content

Add basic test for Modal #53140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 2 commits into from
Closed

Add basic test for Modal #53140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2cb990
Improve codegen to add getDebugProps to components (#53135)
Aug 8, 2025
b775076
Add basic test for Modal (#53140)
cipolleschi Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...codegen/e2e/deep_imports/__tests__/components/__snapshots__/GeneratePropsCpp-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ InterfaceOnlyNativeComponentViewProps::InterfaceOnlyNativeComponentViewProps(
const InterfaceOnlyNativeComponentViewProps &sourceProps,
const RawProps &rawProps): ViewProps(context, sourceProps, rawProps),

title(convertRawProp(context, rawProps, \\"title\\", sourceProps.title, {\\"\\"})) {}
title(convertRawProp(context, rawProps, \\"title\\", sourceProps.title, {std::string{\\"\\"}})) {}

#ifdef RN_SERIALIZABLE_STATE
ComponentName InterfaceOnlyNativeComponentViewProps::getDiffPropsImplementationTarget() const {
Expand Down Expand Up @@ -1060,7 +1060,7 @@ StringPropNativeComponentViewProps::StringPropNativeComponentViewProps(
const StringPropNativeComponentViewProps &sourceProps,
const RawProps &rawProps): ViewProps(context, sourceProps, rawProps),

placeholder(convertRawProp(context, rawProps, \\"placeholder\\", sourceProps.placeholder, {\\"\\"})),
placeholder(convertRawProp(context, rawProps, \\"placeholder\\", sourceProps.placeholder, {std::string{\\"\\"}})),
defaultValue(convertRawProp(context, rawProps, \\"defaultValue\\", sourceProps.defaultValue, {})) {}

#ifdef RN_SERIALIZABLE_STATE
Expand Down
65 changes: 62 additions & 3 deletions ...e-codegen/e2e/deep_imports/__tests__/components/__snapshots__/GeneratePropsH-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Object {
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/graphics/Color.h>
#include <react/renderer/graphics/Point.h>
#include <react/renderer/graphics/RectangleEdges.h>
Expand Down Expand Up @@ -89,6 +90,7 @@ static inline std::string toString(const ArrayPropsNativeComponentViewSizesMaskW
struct ArrayPropsNativeComponentViewObjectStruct {
std::string prop{};


#ifdef RN_SERIALIZABLE_STATE
bool operator==(const ArrayPropsNativeComponentViewObjectStruct&) const = default;

Expand Down Expand Up @@ -133,6 +135,7 @@ struct ArrayPropsNativeComponentViewArrayOfObjectsStruct {
Float prop1{0.0};
int prop2{0};


#ifdef RN_SERIALIZABLE_STATE
bool operator==(const ArrayPropsNativeComponentViewArrayOfObjectsStruct&) const = default;

Expand Down Expand Up @@ -203,6 +206,8 @@ class ArrayPropsNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -225,6 +230,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -243,6 +249,8 @@ class BooleanPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -265,6 +273,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/graphics/Color.h>

namespace facebook::react {
Expand All @@ -283,6 +292,8 @@ class ColorPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -306,6 +317,7 @@ Object {
#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/core/graphicsConversions.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <yoga/Yoga.h>

namespace facebook::react {
Expand All @@ -324,6 +336,8 @@ class DimensionPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -346,6 +360,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -363,6 +378,8 @@ class EdgeInsetsPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -385,6 +402,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand Down Expand Up @@ -468,6 +486,8 @@ class EnumPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -490,6 +510,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -507,6 +528,8 @@ class EventNestedObjectPropsNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -529,6 +552,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -546,6 +570,8 @@ class EventPropsNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -568,6 +594,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -591,6 +618,8 @@ class FloatPropsNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -613,6 +642,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/imagemanager/primitives.h>

namespace facebook::react {
Expand All @@ -631,6 +661,8 @@ class ImagePropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -653,6 +685,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -672,6 +705,8 @@ class IntegerPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -694,6 +729,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -704,13 +740,15 @@ class InterfaceOnlyNativeComponentViewProps final : public ViewProps {

#pragma mark - Props

std::string title{\\"\\"};
std::string title{std::string{\\"\\"}};

#ifdef RN_SERIALIZABLE_STATE
ComponentName getDiffPropsImplementationTarget() const override;

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -733,6 +771,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -750,6 +789,8 @@ class MixedPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -772,6 +813,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/graphics/Color.h>
#include <react/renderer/graphics/Point.h>
#include <react/renderer/imagemanager/primitives.h>
Expand All @@ -795,6 +837,8 @@ class MultiNativePropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -817,6 +861,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -834,6 +879,8 @@ class NoPropsNoEventsNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -858,6 +905,7 @@ Object {
#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/core/propsConversions.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/graphics/Color.h>
#include <react/renderer/graphics/Point.h>
#include <react/renderer/imagemanager/primitives.h>
Expand Down Expand Up @@ -918,13 +966,14 @@ static inline folly::dynamic toDynamic(const ObjectPropsNativeComponentIntEnumPr
}
#endif
struct ObjectPropsNativeComponentObjectPropStruct {
std::string stringProp{\\"\\"};
std::string stringProp{std::string{\\"\\"}};
bool booleanProp{false};
Float floatProp{0.0};
int intProp{0};
ObjectPropsNativeComponentStringEnumProp stringEnumProp{ObjectPropsNativeComponentStringEnumProp::Small};
ObjectPropsNativeComponentIntEnumProp intEnumProp{ObjectPropsNativeComponentIntEnumProp::IntEnumProp0};


#ifdef RN_SERIALIZABLE_STATE
bool operator==(const ObjectPropsNativeComponentObjectPropStruct&) const = default;

Expand Down Expand Up @@ -983,6 +1032,7 @@ static inline folly::dynamic toDynamic(const ObjectPropsNativeComponentObjectPro
struct ObjectPropsNativeComponentObjectArrayPropStruct {
std::vector<std::string> array{};


#ifdef RN_SERIALIZABLE_STATE
bool operator==(const ObjectPropsNativeComponentObjectArrayPropStruct&) const = default;

Expand Down Expand Up @@ -1018,6 +1068,7 @@ struct ObjectPropsNativeComponentObjectPrimitiveRequiredPropStruct {
SharedColor color{};
Point point{};


#ifdef RN_SERIALIZABLE_STATE
bool operator==(const ObjectPropsNativeComponentObjectPrimitiveRequiredPropStruct&) const = default;

Expand Down Expand Up @@ -1073,6 +1124,8 @@ class ObjectPropsNativeComponentProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -1095,6 +1148,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>
#include <react/renderer/graphics/Point.h>

namespace facebook::react {
Expand All @@ -1113,6 +1167,8 @@ class PointPropNativeComponentViewProps final : public ViewProps {

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand All @@ -1135,6 +1191,7 @@ Object {

#include <react/renderer/components/view/ViewProps.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/debug/DebugStringConvertible.h>

namespace facebook::react {

Expand All @@ -1145,14 +1202,16 @@ class StringPropNativeComponentViewProps final : public ViewProps {

#pragma mark - Props

std::string placeholder{\\"\\"};
std::string placeholder{std::string{\\"\\"}};
std::string defaultValue{};

#ifdef RN_SERIALIZABLE_STATE
ComponentName getDiffPropsImplementationTarget() const override;

folly::dynamic getDiffProps(const Props* prevProps) const override;
#endif


};

} // namespace facebook::react
Expand Down
Loading
Loading