Add tests for Modal.animationStyle prop#53141
Closed
cipolleschi wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
from
82cbd0d to
c3adba8
Compare
cipolleschi
force-pushed
the
export-D79808162
branch
from
c3adba8 to
28b7445
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
from
28b7445 to
9596cc7
Compare
cipolleschi
force-pushed
the
export-D79808162
branch
from
9596cc7 to
1c43fdc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
2 times, most recently
from
baca2ea to
5e1a44f
Compare
cipolleschi
force-pushed
the
export-D79808162
branch
2 times, most recently
from
3bfd9fc to
08217be
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
2 times, most recently
from
80b6034 to
8f3e8f7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
from
8f3e8f7 to
29a4416
Compare
added 2 commits
August 8, 2025 03:46
Summary: Pull Request resolved: facebook#53135 Our Codegenerated components are not generating code for `getDebugProps`. This change modifies Codegen to add those functions for all the codegen components. ## Changelog: [General][Added] - Added getDebugProps to codegen ## Facebook: `getDebugProps` are required by Fantom to write tests. However, we can't generate these function for third party components, because codegen can generate arbitrary structs and we don't have a generic `toString()` method that can be used or automatically generated by C++. By generating this function only for Core Components, we can ensure that we can write Fantom tests without breaking all the users of React Native. Differential Revision: D79805145 Reviewed By: rubennorte
Summary: Pull Request resolved: facebook#53140 As per title, this change adds the boilerplate code for a Fantom test on Modal ## Changelog: [Internal] - Differential Revision: D79805808 Reviewed By: andrewdacenko
cipolleschi
force-pushed
the
export-D79808162
branch
from
29a4416 to
30fd733
Compare
Summary: Pull Request resolved: facebook#53141 Add Fantom tests for Modal.animationStyle prop ## Changelog: [Internal] - Reviewed By: andrewdacenko, rubennorte Differential Revision: D79808162
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79808162 |
cipolleschi
force-pushed
the
export-D79808162
branch
from
30fd733 to
89c9297
Compare
Contributor
|
This pull request has been merged in 20c91f2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add Fantom tests for Modal.animationStyle prop
Changelog:
[Internal] -
Differential Revision: D79808162