Rename minDuration as minTestExecutionTime for clarity#53321
Closed
rubennorte wants to merge 3 commits into
Closed
Rename minDuration as minTestExecutionTime for clarity#53321rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404378 |
rubennorte
force-pushed
the
export-D80404378
branch
from
12ef987 to
663fc19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404378 |
rubennorte
force-pushed
the
export-D80404378
branch
from
663fc19 to
043881b
Compare
Summary: Changelog: [internal] This just makes it easier to understand when the benchmark itself has started running and how long the benchmark itself took to run. Reviewed By: rshest Differential Revision: D80400268
Summary: Changelog: [internal] This changes the types for benchmark functions to improve safety: 1. It makes the return object be an object instead of an interface, to catch when `overriddenDuration` is misspelled. 2. It makes the function always synchronous, as asynchronous tests aren't supported in Fantom (even though they are in `tinybench`). Reviewed By: rshest Differential Revision: D80404121
Summary: Changelog: [internal] Just a rename to make it easier to understand. Reviewed By: rshest Differential Revision: D80404378
rubennorte
force-pushed
the
export-D80404378
branch
from
043881b to
d1e9630
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80404378 |
Contributor
|
This pull request has been merged in 219fc99. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just a rename to make it easier to understand.
Differential Revision: D80404378