Delete internal ReactPackageLogger as no longer necessary#53387
Closed
cortinico wants to merge 2 commits into
Closed
Delete internal ReactPackageLogger as no longer necessary#53387cortinico wants to merge 2 commits into
ReactPackageLogger as no longer necessary#53387cortinico wants to merge 2 commits into
Conversation
Summary: This method is deprecated and should not be invoked in NewArch, therefore I'm deprecating it now. Changelog: [Android] [Deprecated] - Deprecate `BridgelessReactContext.getCatalystInstance()` method Reviewed By: cipolleschi Differential Revision: D80626638
Summary: This interface was internal and legacy arch only, so it can safely be removed. I've also removed the logic inside `ReactInstanceManager` that was using it as no longer necessary. Changelog: [Internal] [Changed] - Reviewed By: mdvacca Differential Revision: D80626639
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80626639 |
Contributor
|
This pull request has been merged in 8bdb347. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This interface was internal and legacy arch only, so it can safely be removed.
I've also removed the logic inside
ReactInstanceManagerthat was using it as no longer necessary.Changelog:
[Internal] [Changed] -
Reviewed By: mdvacca
Differential Revision: D80626639