Skip to content

Delete internal ReactPackageLogger as no longer necessary #53387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cortinico wants to merge 2 commits into from
Closed

Delete internal ReactPackageLogger as no longer necessary #53387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a5cb2
Deprecate `BridgelessReactContext.getCatalystInstance()`
cortinico Aug 21, 2025
4c379cb
Delete internal `ReactPackageLogger` as no longer necessary
cortinico Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ internal class CoreModulesPackage(
private val hardwareBackBtnHandler: DefaultHardwareBackBtnHandler,
private val lazyViewManagersEnabled: Boolean,
private val minTimeLeftInFrameForNonBatchedOperationMs: Int,
) : BaseReactPackage(), ReactPackageLogger {
) : BaseReactPackage() {
/**
* This method is overridden, since OSS does not run the annotation processor to generate
* [CoreModulesPackage.ReactModuleInfoProvider] class. Here we check if it exists with the method
Expand Down Expand Up @@ -196,14 +196,6 @@ internal class CoreModulesPackage(
}
}

override fun startProcessPackage() {
ReactMarker.logMarker(ReactMarkerConstants.PROCESS_CORE_REACT_PACKAGE_START)
}

override fun endProcessPackage() {
ReactMarker.logMarker(ReactMarkerConstants.PROCESS_CORE_REACT_PACKAGE_END)
}

private companion object {
init {
LegacyArchitectureLogger.assertLegacyArchitecture(
Expand Down
7 changes: 0 additions & 7 deletions ...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,14 +1570,7 @@ private void processPackage(
SystraceMessage.beginSection(TRACE_TAG_REACT, "processPackage")
.arg("className", reactPackage.getClass().getSimpleName())
.flush();
if (reactPackage instanceof ReactPackageLogger) {
((ReactPackageLogger) reactPackage).startProcessPackage();
}
nativeModuleRegistryBuilder.processPackage(reactPackage);

if (reactPackage instanceof ReactPackageLogger) {
((ReactPackageLogger) reactPackage).endProcessPackage();
}
SystraceMessage.endSection(TRACE_TAG_REACT).flush();
}

Expand Down
20 changes: 0 additions & 20 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageLogger.kt
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions ...ct-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ internal class BridgelessReactContext(context: Context, private val reactHost: R
override fun getFabricUIManager(): UIManager? = reactHost.uiManager

@OptIn(FrameworkAPI::class)
@Deprecated(
"This method is deprecated in the New Architecture. You should not be invoking directly as we're going to remove it in the future."
)
override fun getCatalystInstance(): CatalystInstance {
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {
throw UnsupportedOperationException(
Expand Down
Loading