Fix unkown name for Timestamps on Timings track#53854
Closed
hoxyq wants to merge 2 commits into
Closed
Conversation
Contributor
…ook#53853) Summary: # Changelog: [Internal] Chrome DevTools orders tracks based on the timestamp of the first entry. For React on Web we emit a few entries to establish the ordering: https://github.com/facebook/react/blob/6eda534718d09a26d58d65c0a376e05d7e2a3358/packages/react-reconciler/src/ReactFiberPerformanceTrack.js#L57-L96 We are doing the same thing here, but in C++. Differential Revision: D82811889
Summary: # Changelog: [Internal] This fixes the unkown names message for TimeStamps on Timings track Differential Revision: D82812849
95f6c9f to
e1599b7
Compare
Contributor
Contributor
|
This pull request has been merged in 0e77015. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This fixes the unkown names message for TimeStamps on Timings track
Differential Revision: D82812849