Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ std::optional<std::vector<TraceEvent>> PerformanceTracer::stopTracing() {
tracingAtomic_ = false;
performanceMeasureCount_ = 0;

alreadyEmittedEntryForComponentsTrackOrdering_ = false;
events = collectEventsAndClearBuffers(currentTraceEndTime);
}

Expand Down Expand Up @@ -550,11 +551,8 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
});
},
[&](PerformanceTracerEventTimeStamp&& event) {
// `name` takes precedence over `message` in Chrome DevTools
// Frontend, no need
// to record both.
folly::dynamic data =
folly::dynamic::object("name", std::move(event.name));
folly::dynamic data = folly::dynamic::object("name", event.name)(
"message", std::move(event.name));
if (event.start) {
if (std::holds_alternative<HighResTimeStamp>(*event.start)) {
data["start"] = highResTimeStampToTracingClockTimeStamp(
Expand All @@ -571,6 +569,34 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
data["end"] = std::move(std::get<std::string>(*event.end));
}
}

// We add a custom synthetic entry here to manually put Components
// track right under the Scheduler track. Will be removed once CDT
// Frontend preserves track ordering and we upgrade the fork.
if (!alreadyEmittedEntryForComponentsTrackOrdering_ &&
event.trackName && !event.trackGroup) {
if (*event.trackName == "Components \u269B") {
alreadyEmittedEntryForComponentsTrackOrdering_ = true;
// React is using 0.003 for Scheduler sub-tracks.
auto timestamp = highResTimeStampToTracingClockTimeStamp(
HighResTimeStamp::fromDOMHighResTimeStamp(0.004));
events.emplace_back(TraceEvent{
.name = "TimeStamp",
.cat = "devtools.timeline",
.ph = 'I',
.ts = event.createdAt,
.pid = processId_,
.tid = event.threadId,
.args = folly::dynamic::object(
"data",
folly::dynamic::object(
"name", "ReactNative-ComponentsTrack")(
"start", timestamp)("end", timestamp)(
"track", *event.trackName)),
});
}
}

if (event.trackName) {
data["track"] = std::move(*event.trackName);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,10 @@ class PerformanceTracer {
std::vector<PerformanceTracerEvent>* previousBuffer_{};
HighResTimeStamp currentBufferStartTime_;

// A flag that is used to ensure we only emit one auxiliary entry for the
// ordering of Scheduler / Component tracks.
bool alreadyEmittedEntryForComponentsTrackOrdering_ = false;

/**
* Protects data members of this class for concurrent access, including
* the tracingAtomic_, in order to eliminate potential "logic" races.
Expand Down
Loading