Migrate JSPointerDispatcher to Kotlin#56910
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105847417. |
Summary:
Convert `JSPointerDispatcher` from Java to Kotlin as part of the ongoing React Native Android migration to 100% Kotlin. This follows the same pattern as the recent `JSTouchDispatcher` migration; the class becomes `final` in the API surface (Kotlin default), which is intentional since the class is not part of the supported public API.
Adjacent changes required by the migration:
- Remove `JSPointerDispatcher.java` from the `ReactNoNewJavaDetector` allow-list.
- Regenerate `ReactAndroid.api` to reflect the `final` modifier added to the class and its methods.
- Fix one internal caller (`EmbeddedReactView`) whose `eventDispatcher` was being passed without a null-check; the call is now wrapped in the same `eventDispatcher?.let { ... }` pattern that already guards `jsTouchDispatcher` immediately above it.
Changelog: [Internal]
Differential Revision: D105847417
cortinico
force-pushed
the
export-D105847417
branch
from
aa85224 to
434ee14
Compare
|
This pull request has been merged in f1cd007. |
Collaborator
|
This pull request was successfully merged by @cortinico in f1cd007 When will my fix make it into a release? | How to file a pick request? |
2 tasks
kirillzyusko
pushed a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Jun 1, 2026
## 📜 Description JSPointerDispatcher became a final Kotlin class in React Native 0.87+ (after the Java-to-Kotlin migration in facebook/react-native#56910), so JSPointerDispatcherCompat can no longer extend it. While I'm restoring it in: - facebook/react-native#57022 Ideally we would want to reduce the API surface of RN apis. So here I'm switching from inheritance to composition by holding an internal JSPointerDispatcher delegate and forwarding calls to it. ## 🤔 How Has This Been Tested? Looking for guidance on how to test this. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> ## 📸 Screenshots (if appropriate): N/A <!-- Add screenshots/video if needed --> <!-- That would be highly appreciated if you can add how it looked before and after your changes --> ## 📝 Checklist - [ ] CI successfully passed - [ ] I added new mocks and corresponding unit-tests if library API was changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Convert
JSPointerDispatcherfrom Java to Kotlin as part of the ongoing React Native Android migration to 100% Kotlin. This follows the same pattern as the recentJSTouchDispatchermigration; the class becomesfinalin the API surface (Kotlin default), which is intentional since the class is not part of the supported public API.Adjacent changes required by the migration:
JSPointerDispatcher.javafrom theReactNoNewJavaDetectorallow-list.ReactAndroid.apito reflect thefinalmodifier added to the class and its methods.EmbeddedReactView) whoseeventDispatcherwas being passed without a null-check; the call is now wrapped in the sameeventDispatcher?.let { ... }pattern that already guardsjsTouchDispatcherimmediately above it.Changelog: [Internal]
Differential Revision: D105847417